Revert weak authorizeURLHandler. Add method weak() function to se…

…t weak explicitely #526 #522

OAuthSwift.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
  s.name = 'OAuthSwift'
- s.version = '1.4.0'
+ s.version = '1.4.1'
  s.license = 'MIT'
  s.summary = 'Swift based OAuth library for iOS and macOS.'
  s.homepage = 'https://github.com/OAuthSwift/OAuthSwift'

Sources/OAuthSwift.swift

@@ -18,19 +18,7 @@ open class OAuthSwift: NSObject, OAuthSwiftRequestHandle {
  open var version: OAuthSwiftCredential.Version { return self.client.credential.version }
 
  /// Handle the authorize url into a web view or browser
- open var authorizeURLHandler: OAuthSwiftURLHandlerType {
- get {
- if let proxy = _authorizeURLHandler as? OAuthSwiftURLHandlerProxy {
- return proxy.proxiable ?? _authorizeURLHandler
- }
- return _authorizeURLHandler
- }
- set {
- _authorizeURLHandler = OAuthSwiftURLHandlerProxy(newValue)
- }
- }
-
- var _authorizeURLHandler: OAuthSwiftURLHandlerType = OAuthSwiftOpenURLExternally.sharedInstance
+ open var authorizeURLHandler: OAuthSwiftURLHandlerType = OAuthSwiftOpenURLExternally.sharedInstance
 
  fileprivate var currentRequests: [String: OAuthSwiftRequestHandle] = [:]
 

Sources/OAuthSwiftURLHandlerType.swift

@@ -224,12 +224,19 @@ open class ExtensionContextURLHandler: OAuthSwiftURLHandlerType {
 }
 
 // MARK: Proxy
-class OAuthSwiftURLHandlerProxy: OAuthSwiftURLHandlerType {
+open class OAuthSwiftURLHandlerProxy: OAuthSwiftURLHandlerType {
  weak var proxiable: OAuthSwiftURLHandlerType?
- init(_ proxiable: OAuthSwiftURLHandlerType) {
+ public init(_ proxiable: OAuthSwiftURLHandlerType) {
  self.proxiable = proxiable
  }
- func handle(_ url: URL) {
+ open func handle(_ url: URL) {
  proxiable?.handle(url)
  }
 }
+
+extension OAuthSwiftURLHandlerType {
+
+ public func weak() -> OAuthSwiftURLHandlerType {
+ return OAuthSwiftURLHandlerProxy(self)
+ }
+}