Remove inverseOf class axioms #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry did I merge the other one too quickly...? |
|
@cmungall Nope, it's all good! I created that PR because I noticed the genid issue while making this PR—I deleted one axiom comment annotation here because the change to InverseOf rendered the comment unnecessary, then noticed it fixed the genid problem for that term, so I opened up that other PR to fix the rest of the genids. |
|
At least, that's a no on the technical side—not sure if there was any desire to review it. |
matentzn
approved these changes
Aug 16, 2024
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229. Replaces inverseOf class axioms with genuine inverse relations.