Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft docker deploy for OBO site #1805

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Draft docker deploy for OBO site #1805

wants to merge 2 commits into from

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Feb 18, 2022 •
edited
Loading

Fixes #557

cthoyt
cthoyt reviewed Feb 18, 2022
View reviewed changes
Makefile
#### Commands for building the Docker image ####
################################################
VERSION = "0.0.1"
IM=obolibrary/site
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cryptic variable name

cthoyt
cthoyt reviewed Feb 18, 2022
View reviewed changes
Makefile
################################################
#### Commands for building the Docker image ####
################################################
VERSION = "0.0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very descriptive. Suggetion: OBOFOUNDRY_IMAGE_VERSION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not review draft pull requests :P

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I didn't look at the flag

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd hate working on one of my open source projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its like looking at someone six pack in progress under their t-shirt on January 10.

@nlharris nlharris mentioned this pull request May 24, 2022
Open
@matentzn
Copy link
Contributor Author

@erik-whiting can you drive this PR to completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@erik-whiting erik-whiting

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a Dockerfile for OBOFoundry.github.io repo
3 participants
@matentzn @cthoyt @erik-whiting