Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] payment_paypal: improve error handling in paypal validation #1222

Open
wants to merge 1 commit into
base: 10.0
Choose a base branch
from
Open

[10.0][IMP] payment_paypal: improve error handling in paypal validation #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion addons/payment_paypal/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ def paypal_validate_data(self, **post):
new_post['cmd'] = '_notify-synch' # command is different in PDT than IPN/DPN
validate_url = paypal_urls['paypal_form_url']
urequest = urllib2.Request(validate_url, werkzeug.url_encode(new_post))
uopen = urllib2.urlopen(urequest)
try:
uopen = urllib2.urlopen(urequest)
except Exception as e:
_logger.exception('PayPal: validation request failed, with url %s, data %s, exception %s', validate_url, new_post, e)
return res
resp = uopen.read()
if pdt_request:
resp, post = self._parse_pdt_response(resp)
Expand Down