[14.0][OU-UPD] rerun analysis for noupdate_changes.xml

[remi-filament]

As per #4356 multi-company security rules have changed.
This PR is the outcome of rerunning analysis, then checking manually each file to keep only what is relevant (and not overwriting noupdate_changes.xml which were manually modified while writing migration scripts)

[OCA-git-bot]

Hi @StefanRijnhart, @MiquelRForgeFlow, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[legalsylvain]

Thanks !

[remi-filament]

Thank @MiquelRForgeFlow for review, I indeed missed a few points ! All resolved

[MiquelRForgeFlow]

LGTM

[legalsylvain]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-4358-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at cdbf530. Thanks a lot for contributing to OCA. ❤️

[pedrobaeza]

Thanks for this, Rémi. Remember that UPD is not a valid tag. It should be IMP or FIX. I think that something similar should be done for v15, as there will be some new company rules there. And maybe it's interesting to force the rewriting unconditionally for those coming from a v14 with old rules.

[remi-filament]

And maybe it's interesting to force the rewriting unconditionally for those coming from a v14 with old rules.

I tried asking Odoo to get update script directly in v14 core, but they answered that there is no need, they would get it when upgrading to next version...
I am not sure what would be the best way-forward for existing DB in v14+ :

1. should we enforce in OpenUpgrade in v15, v16, v17 these noupdate changes for all ir_rules ?
2. should we create a script that could be run directly in existing DB outside of a migration and that could be called by OpenUpgrade (or listed in the doc as prerequisite) when upgrading to v15 / v16 / v17 ?

Solution 1 is probably cleaner, but solution 2 would allow to get performance improvements for existing DB without waiting for migration... (also I am not sure how to make solution 2 since we would need to check for each module if module is installed before updating rules)

[pedrobaeza]

FYI, these code snippets serves for updating existing old instances with the new record rules:

v14: https://gist.github.com/pedrobaeza/81047d9d529eae6fc64dff277f68c291
v15: https://gist.github.com/pedrobaeza/4030e735757571632ae457ed6001d6c5
v16: https://gist.github.com/pedrobaeza/c67693945a4e50607670541cee5cfd6c
v17: https://gist.github.com/pedrobaeza/2ce14433272be5a00d89adaab0f5545d