Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] account: don't set exclude_from_invoice_tab for type entry #4385

Merged

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Apr 8, 2024

when we create an entry in v13, this flag isn't set on move lines for type entry, so the migration shouldn't set it either. Otherwise, we get weird side effects when recomputing ie the balance of such entries

@pedrobaeza
Copy link
Member

I don't get the need of this. exclude_from_invoice_tab=True is the default value for everything except the invoice lines, so when move_type = entry, they should be that value too.

@hbrunn
Copy link
Member Author

hbrunn commented Apr 9, 2024

this one I found on the way to #4386 - we don't exactly need it, but being closer to what the target version does is better, right?

For demonstration, I've just created a move on runboat

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see that indeed Odoo doesn't care about such flag when the move type is entry:

imagen

@pedrobaeza pedrobaeza merged commit 39543a8 into OCA:13.0 Apr 9, 2024
3 checks passed
@hbrunn
Copy link
Member Author

hbrunn commented Apr 9, 2024

I added the column at the beginning ;-)

@pedrobaeza
Copy link
Member

Hehe, didn't see it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants