Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][OU-ADD] crm: Migration to 17.0 #4554

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][OU-ADD] crm: Migration to 17.0 #4554

wants to merge 1 commit into from

Conversation

acpMicrocom
Copy link
Contributor

No description provided.

@legalsylvain legalsylvain added this to the 17.0 milestone Oct 8, 2024
rvalyi
rvalyi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my understanding (I apologize if I'm wrong) we should complete the migration by including a noupdate

@rvalyi
Copy link
Member

rvalyi commented Oct 19, 2024

from my understanding (I apologize if I'm wrong) we should complete the migration by including a noupdate

Sorry, I posted this by mistake, the 2 noupdate records are new:

NEW ir.rule: crm.mail_plan_rule_group_sale_manager_lead (noupdate)
NEW ir.rule: crm.mail_plan_templates_rule_group_sale_manager_lead (noupdate)

So they will be created anyway, right? So in fact I think the PR is OK already, sorry for the noise.

@acpMicrocom acpMicrocom changed the title [17.0][OU-ADD] crm: migration to 17.0 [17.0][OU-ADD] crm: Nothing to do Oct 28, 2024
legalsylvain
legalsylvain requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Some remarks inline.

openupgrade_scripts/scripts/crm/17.0.1.8/upgrade_analysis_work.txt Show resolved Hide resolved
@acpMicrocom acpMicrocom changed the title [17.0][OU-ADD] crm: Nothing to do [17.0][OU-ADD] crm: Migration to 17.0 Oct 28, 2024
@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 29, 2024 •
edited
Loading

/ocabot migration crm

Depends on :

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 29, 2024
Open
80 tasks
This was referenced Oct 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
Blocked by dependency
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@acpMicrocom @rvalyi @legalsylvain