-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][OU-ADD] base: Migration scripts #4582
Conversation
/ocabot migration base |
d5f001a
to
3fe2073
Compare
- Comment some non desirable noupdate=1 changes - Handle properly ir.actions.server update conversion - Handle properly the private type removal - Reformat analysis work file - Other minor adjustments
3fe2073
to
ea7bcc9
Compare
OK, let's merge this as a "base" (wordgame, hehe) for continuing doing the rest of the scripts, and with real tests, we can refine it. |
Thanks @pedrobaeza for taking over this base module migration. From what I can see, the only point that might be problematic during migrations is about ir_act_server with state = 'action_create'. I understand we lose functionalities to set multiple values with new Odoo way of using ir_act_server, maybe we should make it clear somewhere (in the logs or elsewhere ?), I know you point it in upgrade_analysis_work.txt but I am not sure it is visible enough ? |
Yes, right now we don't have a centralized place where informing all of this. Odoo enterprise is putting a chat conversation for system administrators. We may mimic that approach, but sometimes the people reading that may not be suitable to act. And also specifically about actions servers, you shouldn't based your developments on actions servers if you want to be a serious integrator. |
Yes maybe, I have seen it indeed only when updating localisation that they left a message in chat. Maybe all people reading that would not be suitable to act, but in general after a migration I always connect with administrator account to check a few things so I would get the information which seems a good solution !
👍 |
One of the OpenUpgrade principles is to provide a full migration process, including opinionated decisions when there are several choices, so the number of these entries to check should be minimum. |
Supersede of #4430, as there are no push rights there, and Viindoo has said that they are not working more on the migration scripts for now.
Changes performed over existing PR:
@Tecnativa TT49290