Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] product: migrate to 17.0 #4598

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Oct 21, 2024

#4468 with review followup

@hbrunn
Copy link
Member Author

hbrunn commented Oct 21, 2024

/ocabot migration product

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 21, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#4124) has not been updated to reference the current pull request because a previous pull request (#4468) is not closed.
Perhaps you should check that there is no duplicate work.
CC @duong77476-viindoo

@hbrunn
Copy link
Member Author

hbrunn commented Oct 21, 2024

/ocabot migration product

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 21, 2024
80 tasks
Comment on lines 39 to 40
product / product.product / message_main_attachment_id (many2one): DEL relation: ir.attachment
product / product.product / product_document_ids (one2many): NEW relation: product.document
Copy link
Contributor

@remi-filament remi-filament Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hbrunn for taking over this work !
You should probably mark these 2 lines as DONE in post-migration instead of NOTHING TO DO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the first one see my question in the mail PR, agreed with the second, done in 074f09d and will squash when you agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants