[16.0][FIX] pos_analytic_by_config: Avoid prefixing #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefixing the distribution shouldn't be necessary. We can hook into the sales move lines prepare method to add or session info that later can be used to figure out the proper distribution. TT52559
pedrobaeza
changed the title
pedrobaeza
reviewed
Jan 16, 2025
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| """We need to receive this key from the vals as the create call is encampsulated |
There was a problem hiding this comment.
Suggested change
| """We need to receive this key from the vals as the create call is encampsulated | |
| """We need to receive this key from the vals as the create call is encapsulated |
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| """We need to receive this key from the vals as the create call is encampsulated | ||
| inside the _get_sale_vals method of the pos.session model.""" |
There was a problem hiding this comment.
This is not explaining how and where pos_config_id context is used. docstring also puts the trailing """ in a new line according PEP257.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixing the distribution shouldn't be necessary. We can hook into the sales move lines prepare method to add or session info that later can be used to figure out the proper distribution.
cc @Tecnativa TT52559
please review @pedrobaeza @victoralmau
Some doubts that come to my mind: