[IMP] account_financial_report - group rows and hide rows with debit and credit values at 0 #1211
Conversation
techgrrow
commented
Aug 5, 2024
techgrrow
commented
- added join_entry_ml flag to general ledger wizard. This field when flagged joins rows from the same parent record
- added flag to general ledger wizard hat hides rows with both "credit" and "debit" columns with value 0
techgrrow
force-pushed
the
16.0-add-group-invoices-and-rows-0-debit-credit
branch
2 times, most recently
from
4bed585 to
5fbb520
Compare
- added join_entry_ml flag to general ledger wizard. This field when flagged joins rows from the same parent record - added flag that hides rows with both "credit" and "debit" coluns with value 0
techgrrow
force-pushed
the
16.0-add-group-invoices-and-rows-0-debit-credit
branch
from
5fbb520 to
e4d7810
Compare
|
Hi @techgrrow , do you have any plans to finish this PR? |
|
Hi francesco-ooops, what do you mean/what should I do? I'm already using the module. |
|
@techgrrow great to know it's already working well! If you could fix precommit and add some test coverage, then it could be merged into the main branch. Thanks! |
|
@francesco-ooops ok will do as soon as I have (allocated) time! Thanks for the feedback :) |
There was a problem hiding this comment.
@techgrrow just a couple things: can you add details about these new fields' behavior/purpose in CONFIGURATION file?
Also, don't change module version in manifest, as it will be done automatically on merge.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
