Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][FIX] account_financial_report: open_items #853

Open
wants to merge 2 commits into
base: 13.0
Choose a base branch
from
Open

[13.0][FIX] account_financial_report: open_items #853

wants to merge 2 commits into from

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Jan 27, 2022 •
edited
Loading

Fixed the amount_residual_currency on partial reconcile

The amount_residual_currency shown is now is the actual amount_residual_currency, it is not taking into account the partial reconciled records.

@ForgeFlow

Updated:

In order to reproduce the error please do:

  1. Create an invoice for a different currency in 2021
  2. Create a payment in 2022
  3. Run the open items report at the end of 2021

The amount residual is correct but the amount residual currency is incorrect

@AaronHForgeFlow
Copy link
Contributor Author

Need this or the aged_partner_balance will may fail: ForgeFlow#5 Will include that PR here soon.

@rafaelbn rafaelbn added this to the 13.0 milestone Mar 31, 2022
@rafaelbn
Copy link
Member

Hello @AaronHForgeFlow , please could you update this PR?

@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-fix-account_financial_report-open-item-residual-currency branch 3 times, most recently from 739a02a to 981e0ba Compare September 21, 2022 10:06
@are-agilebg are-agilebg mentioned this pull request Oct 10, 2022
Merged
@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed needs fixing labels Oct 25, 2022
@AaronHForgeFlow AaronHForgeFlow force-pushed the 13.0-fix-account_financial_report-open-item-residual-currency branch from 981e0ba to 8726301 Compare December 23, 2022 14:52
@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-fix-account_financial_report-open-item-residual-currency branch 3 times, most recently from 6973f2e to 91e0e34 Compare January 23, 2023 15:43
pedrobaeza
pedrobaeza requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are modifying the arguments of a function in a stable version. This will lead to problems in dependent modules. And there's already amount_residual_currency field in standard AFAIK

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-fix-account_financial_report-open-item-residual-currency branch from 91e0e34 to 6ae1dea Compare March 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@JordiBForgeFlow JordiBForgeFlow Awaiting requested review from JordiBForgeFlow

Assignees
No one assigned
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronHForgeFlow @rafaelbn @pedrobaeza @JordiMForgeFlow