Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] account_financial_report: change report access groups to only 'Show Full Accounting Features' #975

Closed

Conversation

ramiadavid
Copy link
Contributor

Backport of #939

@pedrobaeza

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 24, 2022
@ramiadavid
Copy link
Contributor Author

Hi @pedrobaeza What is it codecov/project and why it fails in many PR's is it not important?

@pedrobaeza
Copy link
Member

It's a measure of the test coverage, but I'm not sure is working correctly on all of the cases. It's ignored most of the times as it's not critical for the module to work, but just a quality measure.

In this PR the problem may be the Travis failing, that don't pass to Codecov all the data.

Anyway, the backport to this older versions is not convenient unless you have explicit interest on it. To cover the currently supported versions is enough as a good contributor :)

@ramiadavid
Copy link
Contributor Author

@pedrobaeza Ok, so I cancel the PR for the previous versions? v11 v10 v9

@pedrobaeza
Copy link
Member

What you prefer. As you have done them already, maybe someone wants it, so let's see the community reaction.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 17, 2023
@github-actions github-actions bot closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants