[13.0][FIX] partner_statement: minor fixes (partial backport) #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
force-pushed
the
13.0-fix-partner_statement-minor-fixes
branch
10 times, most recently
from
659c691 to
531740d
Compare
gdgellatly
requested changes
Feb 9, 2023
MiquelRForgeFlow
force-pushed
the
13.0-fix-partner_statement-minor-fixes
branch
from
531740d to
cddb2f2
Compare
|
Thanks, fixed. |
MiquelRForgeFlow
force-pushed
the
13.0-fix-partner_statement-minor-fixes
branch
from
cddb2f2 to
15b72a1
Compare
MiquelRForgeFlow
force-pushed
the
13.0-fix-partner_statement-minor-fixes
branch
from
e8d5b7d to
ee6366c
Compare
|
@gdgellatly I would like to merge these backport fixes. Is it fine? |
|
@MiquelRForgeFlow I don't know, we are still stuck on a December 2022 release of partner statement because a whole load of changes landed between then and Feb and they produce wrong numbers and in some cases complete nonsense. I haven't checked since about July whether these things have been fixed, but I know the first round of fixes didn't resolve. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
AaronHForgeFlow
added
no stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of some minor fixes done in #967 and #988.