[16.0][mig] account invoice constraint chronology #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice_constraint_chronology [IMP] DEFAULT_SERVER_DATE_FORMAT [IMP] display formatted date with context timezone in exception popup for account_invoice_constraint_chronology addons [ADD] Add context in tests for account_invoice_constraint_chronology addons [IMP] Use exceptions.warning for account_invoice_constraint_chronology addons [IMP] Remove exclamation mark [ADD] Add .pot file for account_invoice_constraint_chronology [IMP] Use .env for account_invoice_constraint_chronology tests [IMP] Use onchange decorator, add white space at end of file, correct ypo mistake for account_invoice_constraint_chronology [IMP] Improve performance
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
It was not used in these tests anyway.
these cause Warnings during the tests
… Dedicated Credit Note Sequence
Addresses the issue as commented here: - OCA#1206 - OCA#1152 (comment) Summary of the steps to reproduce the problem: 1. Set on the invoices journal the constraint chronology. 2. Validate an invoice for this journal today. 3. Your accountant says there's an error on an invoice from yesterday. 4. Cancel it an set it to draft. You don't even need to modify anything 5. Try to post the invoice. 6. You'll get a chronology error. In v12 this was considered but it was lost on the migration to v13: https://github.com/OCA/account-financial-tools/blob/800c02474e5aa43cee592e93499d2a480be46d32/account_invoice_constraint_chronology/model/account_invoice.py#L50 https://github.com/OCA/account-financial-tools/blob/800c02474e5aa43cee592e93499d2a480be46d32/account_invoice_constraint_chronology/model/account_invoice.py#L70-L73 TT34624
|
Hey @AnizR, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
/ocabot migration account_invoice_constraint_chronology |
adrienpeiffer
approved these changes
Oct 19, 2022
|
This PR has the |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 959a97d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of account invoice constraint chronology to version 16