[16.0][MIG] base vat optional vies: Migration to 16.0 #1572

RodrigoBM · 2023-01-26T14:10:52Z

rafaelbn · 2023-01-28T11:00:31Z

/ocabot migration base_vat_optional_vies

rafaelbn · 2023-01-28T11:18:03Z

Hello @RodrigoBM , thank you!! 😄

As a know issue in this module and commented recently by @alexis-via in Twitter https://twitter.com/alexisdlattre/status/1618377832090185730 we should improve of FIX this module in this points:

Premise: as de VAT number in the parent (commercial partner) is the same and should be the same for all chilldren , this field vies_valid too!!

So my proposal is simple:

Propagate field to children: When VIES is valid and this module mark as true the boolean in the parent propagate it to all children contacts.
Improve installation: when the module is installed, and there are already partners created, if we don't make anything the existing partner are not updated.
- My proposal is create a wizard in the installation that ask to update all existing partners. If this is technically complicated or wrong for performance then create an action or something which objetive is update all existing partners.
- Maybe the best way is create a installation script to be all recalculated correctly

This changes could be don't know if easy or later in a separate PR. I'm not blocking at all this great migration.

@moduon MT-2178

Shide

Improvement that can be done in a separate PR, but not blocking migration

Shide · 2023-01-30T06:50:31Z

base_vat_optional_vies/models/res_partner.py

+        for partner in self:
+            partner = partner.with_context(vat_partner=partner)
+            super(ResPartner, partner).check_vat()


Maybe can be improved to propagate vies_passed field to the children contacts:

Suggested change

for partner in self:

partner = partner.with_context(vat_partner=partner)

super(ResPartner, partner).check_vat()

for partner in self.sorted(lambda p: bool(p.commercial_partner_id)):

partner = partner.with_context(vat_partner=partner)

if partner.commercial_partner_id:

partner.update({"vies_passed": partner.commercial_partner_id.vies_passed})

else:

super(ResPartner, partner).check_vat()

RodrigoBM · 2023-01-30T17:51:52Z

with this commit in base_vat odoo/odoo@eff3b14 this mig now fails. I am reviewing it

* Disable VIES test * Fixes to avoid exception when using default _construct_constraint_msg method

* base_vat_optional_vies: Fix pass lower country code in _split_vat function to find parent function check_vat_'xx' instead of check_vat_'XX' * base_vat_optional_vies: Convert to upper when write NIF into database

Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-10.0/account-financial-tools-10.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-10-0/account-financial-tools-10-0-base_vat_optional_vies/de/

Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-base_vat_optional_vies/es/

Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-base_vat_optional_vies/hr/

Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-base_vat_optional_vies/pt/

- Simple VAT error message when an error must be shown - Always clean vies_passed field when check_vat is called [FIX] tests [FIX] Contributor emails

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-15.0/account-financial-tools-15.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-base_vat_optional_vies/

…vat_shows_simple_message

Currently translated at 100.0% (3 of 3 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-base_vat_optional_vies Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-base_vat_optional_vies/pt/

…the change odoo/odoo@eff3b14

pedrobaeza · 2023-01-31T13:35:35Z

Does this module now makes sense as Odoo already made the VIES check optional?

fcvalgar

LGTM.
Thank you @RodrigoBM

fcvalgar · 2023-01-31T17:11:33Z

Hello @RodrigoBM , thank you!! smile

As a know issue in this module and commented recently by @alexis-via in Twitter https://twitter.com/alexisdlattre/status/1618377832090185730 we should improve of FIX this module in this points:

Premise: as de VAT number in the parent (commercial partner) is the same and should be the same for all chilldren , this field vies_valid too!!

So my proposal is simple:

Propagate field to children: When VIES is valid and this module mark as true the boolean in the parent propagate it to all children contacts.

Improve installation: when the module is installed, and there are already partners created, if we don't make anything the existing partner are not updated.

My proposal is create a wizard in the installation that ask to update all existing partners. If this is technically complicated or wrong for performance then create an action or something which objetive is update all existing partners.

Maybe the best way is create a installation script to be all recalculated correctly

This changes could be don't know if easy or later in a separate PR. I'm not blocking at all this great migration.

@moduon Moduon - Task #2178

Initial validation of existing partners would be critical.

fcvalgar · 2023-01-31T17:17:16Z

Does this module now makes sense as Odoo already made the VIES check optional?

It is a very user-friendly validation system without the need for external tools.

It also allows to trace, review and identify validation errors for non-technical users.

For me it is useful as a functional user.

OCA-git-bot · 2023-01-31T17:18:05Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2023-01-31T17:20:01Z

Fran, but have you seen now how it's done on core? They have put a visible warning.

fcvalgar · 2023-01-31T17:34:38Z

Fran, but have you seen now how it's done on core? They have put a visible warning.

It is probably my ignorance but it would only be a warning at the time of creation.

https://www.odoo.com/documentation/16.0/es/applications/finance/accounting/taxation/taxes/vat_validation.html

If I have a team member who wants to verify if that company has passed validation haven't the same information visually.

If this new validation would leave log. The financial and administrative departments ❤️.

pedrobaeza · 2023-01-31T17:58:24Z

OK, I agree it can be useful to check it later, not only on VAT number onchange.

rafaelbn

Tested 👍 still needed Odoo core check it but don't allow to safe a VAT number si VIES is not valid. So the need is the same from v8 😄

/ocabot merge patch

OCA-git-bot · 2023-02-02T15:44:34Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1572-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot · 2023-02-02T15:52:07Z

Congratulations, your PR was merged at 9211879. Thanks a lot for contributing to OCA. ❤️

RodrigoBM force-pushed the 16.0-mig-base_vat_optional_vies branch from 12a9fd8 to 5dec75f Compare January 26, 2023 14:24

RodrigoBM mentioned this pull request Jan 26, 2023

Migration to version 16.0 #1472

Open

33 tasks

rafaelbn added the needs review label Jan 28, 2023

OCA-git-bot added this to the 16.0 milestone Jan 28, 2023

rafaelbn requested review from Shide and yajo January 29, 2023 23:36

Shide approved these changes Jan 30, 2023

View reviewed changes

RodrigoBM force-pushed the 16.0-mig-base_vat_optional_vies branch from 215d21e to 359a065 Compare January 31, 2023 01:12

RodrigoBM requested review from Shide and removed request for yajo January 31, 2023 01:13

RodrigoBM force-pushed the 16.0-mig-base_vat_optional_vies branch from eb3dd33 to 40f5fe4 Compare January 31, 2023 08:27

antespi and others added 16 commits January 31, 2023 14:33

[ADD] base_vat_optional_vies

6ba2b16

* Disable VIES test * Fixes to avoid exception when using default _construct_constraint_msg method

[FIX] Some fixes:

36106a4

* base_vat_optional_vies: Fix pass lower country code in _split_vat function to find parent function check_vat_'xx' instead of check_vat_'XX' * base_vat_optional_vies: Convert to upper when write NIF into database

[MIG] base_vat_optional_vies: Migration to 10.0

324aa9e

[MIG] base_vat_optional_vies: Migration to 11.0

522476d

[MIG] base_vat_optional_vies: Migration to 12.0

252a7bb

[UPD] Update base_vat_optional_vies.pot

db02176

[UPD] README.rst

4c40f09

[FIX] base_vat_optional_vies: Remove contraints on dotted names

9450bbd

base_vat_optional_vies 12.0.1.0.1

81c2094

Added translation using Weblate (Spanish)

b171071

Added translation using Weblate (Croatian)

cfdfa02

Added translation using Weblate (Portuguese)

bfdb0b1

Shide and others added 11 commits January 31, 2023 14:33

[FIX] Simple VAT error message, always clean vies_passed field

bdc3bf6

- Simple VAT error message when an error must be shown - Always clean vies_passed field when check_vat is called [FIX] tests [FIX] Contributor emails

[UPD] Update base_vat_optional_vies.pot

dd4f995

[UPD] README.rst

f1339d4

base_vat_optional_vies 15.0.1.0.2

15a18cb

[FIX] Set country id with ref, one line exercise test_validate_wrong_…

b5e81d3

…vat_shows_simple_message

base_vat_optional_vies 15.0.1.0.3

d460406

[IMP] base_vat_optional_vies: pre-commit stuff

8042d2b

[MIG] base_vat_optional_vies: Migration to 16.0

46303c4

[REF] base_vat_optional_vies: refactor the code to make it valid for …

604871b

…the change odoo/odoo@eff3b14

RodrigoBM force-pushed the 16.0-mig-base_vat_optional_vies branch from 40f5fe4 to 604871b Compare January 31, 2023 13:33

fcvalgar approved these changes Jan 31, 2023

View reviewed changes

OCA-git-bot added the approved label Jan 31, 2023

OCA-git-bot added the ready to merge label Jan 31, 2023

rafaelbn approved these changes Feb 2, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 2, 2023

OCA-git-bot merged commit e72fa0b into OCA:16.0 Feb 2, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 2, 2023

RodrigoBM deleted the 16.0-mig-base_vat_optional_vies branch February 2, 2023 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] base vat optional vies: Migration to 16.0 #1572

[16.0][MIG] base vat optional vies: Migration to 16.0 #1572

RodrigoBM commented Jan 26, 2023 •

edited

Loading

rafaelbn commented Jan 28, 2023

rafaelbn commented Jan 28, 2023

Shide left a comment

Shide Jan 30, 2023

RodrigoBM commented Jan 30, 2023

pedrobaeza commented Jan 31, 2023

fcvalgar left a comment

fcvalgar commented Jan 31, 2023

fcvalgar commented Jan 31, 2023

OCA-git-bot commented Jan 31, 2023

pedrobaeza commented Jan 31, 2023

fcvalgar commented Jan 31, 2023 •

edited

Loading

pedrobaeza commented Jan 31, 2023

rafaelbn left a comment

OCA-git-bot commented Feb 2, 2023

OCA-git-bot commented Feb 2, 2023

[16.0][MIG] base vat optional vies: Migration to 16.0 #1572

[16.0][MIG] base vat optional vies: Migration to 16.0 #1572

Conversation

RodrigoBM commented Jan 26, 2023 • edited Loading

rafaelbn commented Jan 28, 2023

rafaelbn commented Jan 28, 2023

Shide left a comment

Choose a reason for hiding this comment

Shide Jan 30, 2023

Choose a reason for hiding this comment

RodrigoBM commented Jan 30, 2023

pedrobaeza commented Jan 31, 2023

fcvalgar left a comment

Choose a reason for hiding this comment

fcvalgar commented Jan 31, 2023

fcvalgar commented Jan 31, 2023

OCA-git-bot commented Jan 31, 2023

pedrobaeza commented Jan 31, 2023

fcvalgar commented Jan 31, 2023 • edited Loading

pedrobaeza commented Jan 31, 2023

rafaelbn left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 2, 2023

OCA-git-bot commented Feb 2, 2023

RodrigoBM commented Jan 26, 2023 •

edited

Loading

fcvalgar commented Jan 31, 2023 •

edited

Loading