[16.0][MIG] account_asset_batch_compute: Migration to 16.0 #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
JavierIniesta
force-pushed
the
16.0-mig-account_asset_batch_compute
branch
from
6d8da2a
to
ba267d5
Compare
ljsalvatierra-factorlibre
suggested changes
Mar 14, 2023
JavierIniesta
changed the title
|
We have done functional tests and it works correctly. |
RodrigoBM
approved these changes
Apr 13, 2023
ljsalvatierra-factorlibre
approved these changes
May 19, 2023
RodrigoBM
suggested changes
May 28, 2023
| def asset_compute(self): | ||
| self.ensure_one() | ||
| if not self.batch_processing: | ||
| return super(AccountAssetCompute, self).asset_compute() |
There was a problem hiding this comment.
Apply PEP 3135 (28-Apr-2007) to "super()."
JavierIniesta
force-pushed
the
16.0-mig-account_asset_batch_compute
branch
from
ba267d5
to
8adec89
Compare
RodrigoBM
approved these changes
May 29, 2023
|
is it possible to merge this PR? @OCA/accounting-maintainers |
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 94f650e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 16.0
#1472