-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_move_force_removal: Migration to 16.0 #1776
[16.0][MIG] account_move_force_removal: Migration to 16.0 #1776
Conversation
fc933a0
to
0e08349
Compare
Hi @pedrobaeza, the pre commit is broken here https://translation.odoo-community.org/translate/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/pt_BR/?checksum=0677552d31f6588b&sort_by=-priority,position I need to fix this translation, but I can't translate in this language, can you help me? Thank you so much |
You should fix it here in the migration, not on Weblate. The problem is that there are markers (like |
ok thank you |
f12abc1
to
4665732
Compare
Hi Pedro, thank you for reply, but seems the solution of fix translation in migration is not working; in po file of pt_BR language ther is an error about key in message, as can be seen here https://github.com/OCA/account-financial-tools/blob/16.0/account_invoice_constraint_chronology/i18n/pt_BR.po#L68 |
You should replace |
I think that should be do in weblate and not in pr, but for now I do an isolated commit to fix the problem |
Yes, indeed it should be also fixed on previous versions on Weblate, but as this is something out of our scope, let's fix it here at least. |
it's ok for me, and tomorrow I will try to fix the test |
On an integration enviroment, the test may fail searching for an account that belongs to other company. Now we specifically look the an account in current company.
Running the migration script fails with: AttributeError: 'psycopg2.extensions.cursor' object has no attribute 'ref' @moduon
Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_move_force_removal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_move_force_removal/es_AR/
Currently translated at 100.0% (2 of 2 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_move_force_removal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_move_force_removal/es/
c8961f8
to
0da6d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andreampiovesana questo modulo non occorre per 16.0 ho smesso di migrarlo per quello ora la chiudo la pr |
inoltre i test fallivano non ha senso approvare una pr cosi |
Please talk in this repository in English |
No description provided.