Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][BACKPORT] account_move_post_date_user #1971

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

JoanSForgeFlow
Copy link

@JoanSForgeFlow JoanSForgeFlow commented Nov 18, 2024

Backport of account_move_post_date_user from 13.0

cc: @JordiMForgeFlow

JordiMForgeFlow and others added 10 commits November 14, 2024 16:33
Currently translated at 100.0% (3 of 3 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_post_date_user
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_post_date_user/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_post_date_user
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_post_date_user/it/
Backport module from OCA#1822
In order to adapt it to v13.0, the `_post` method has been renamed to `post` and adapting the logic. Also, the importing on tests has been adapted.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_post_date_user
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_post_date_user/
@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-bkp-account_move_post_date_user branch from 9987773 to eee6a7c Compare November 18, 2024 09:32
@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-bkp-account_move_post_date_user branch from eee6a7c to ba99cc2 Compare November 18, 2024 09:42
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review 👍🏼

Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! functional and code review 👍🏿
A minor comment, perhaps the commit message should be BKP or something that does not relate to a migration?

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@JoanSForgeFlow JoanSForgeFlow force-pushed the 12.0-bkp-account_move_post_date_user branch from ba99cc2 to e1157ac Compare November 18, 2024 09:53
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1971-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8c65cea into OCA:12.0 Nov 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 344452f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants