Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][12.0] account_template_active #978

Merged
merged 1 commit into from
May 24, 2021

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented May 4, 2020

This module allows to disable account template items, adding
an active field on the following models:

  • account.account.template

account_account_template_tree

  • account.fiscal.position.template and it two related models
    • account.fiscal.position.account.template
    • account.fiscal.position.tax.template

account_fiscal_position_template_form

This module can be interesting in a multi company context,
if you install a lot of accounting templates, with some changes.

It can also be interesting if you want to developp a custom localization
module based on the official one, but with some removed / added / altered items.

Note:

  • The field active is present in the Odoo account module for the model
    account.tax.template. for that field, this module only adds the active
    field on the tree view.

account_tax_template_tree

#GRAPOCA

@legalsylvain legalsylvain added this to the 12.0 milestone May 4, 2020
@legalsylvain legalsylvain force-pushed the 12.0-ADD-account_template_active branch from 34bd354 to fe64a92 Compare May 4, 2020 17:00
@legalsylvain legalsylvain marked this pull request as ready for review May 4, 2020 17:00
Copy link

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed this module on my computer
I also installed these modules to see the menus indicated:

account_group_menu
account_menu
account_tag_menu
account_type_menu

Everything works as shown
Thanks for this module

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functional review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

Nice module! I ported it to 14.0: #1187. Please squash commits in this PR.

@legalsylvain legalsylvain force-pushed the 12.0-ADD-account_template_active branch from 78c89af to 21d43bf Compare May 24, 2021 08:27
@legalsylvain
Copy link
Contributor Author

Hi all. thanks for your review.
@StefanRijnhart : I squashed commits & reviewed the v14 branch.

I think this PR can be merged.

regards.

@StefanRijnhart
Copy link
Member

Thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-978-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 77bab23 into OCA:12.0 May 24, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7010672. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants