-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG]account_fiscal_position_autodetect_optional_vies: Migration to 17.0 #411
[17.0][MIG]account_fiscal_position_autodetect_optional_vies: Migration to 17.0 #411
Conversation
…dds vat VIES validation to fiscal positions. TT30631
… type in test partner After OCA/OCB@4518968#diff-1ef5fe83935572c9b9b9e6eec69a44551023f3b92fe38bed4f765a24e16694b4 and OCA/OCB@198a4dd the associated partner needs to be of type `company` for the vies check to work. @Tecnativa
…n contacts Steps to reproduce the problem: - Create a partner with a proper VIES VAT. - Create a children for that partner. - Create a fiscal position with "Vat was VIES validated" and "Auto-apply" marks checked. - Use the children partner in an invoice. Current behavior: The fiscal position is not selected. Expected behavior: The fiscal position is selected. TT38107
a46563d
to
7ee159e
Compare
@Jesarregui @HaraldPanten could u review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
This PR has the |
/ocabot migration account_fiscal_position_autodetect_optional_vies |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 21aa424. Thanks a lot for contributing to OCA. ❤️ |
The optional vies field is now part of the core of Odoo. So, changes have been done assuming base_vat_optional_vies is not going to be migrated to 17.0