Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [RFC] Account Payment Return Import SEPA PAIN: reason codes #226

Closed
ThomasBinsfeld opened this issue Feb 25, 2019 · 5 comments
Closed
Assignees

Comments

@ThomasBinsfeld
Copy link
Contributor

ThomasBinsfeld commented Feb 25, 2019

The ISO20022 documentation lists 225 return codes while the OCA addon lists 20 codes. Shouldn't all these missing codes be added in the OCA addon?

@pedrobaeza
Copy link
Member

Well, I don't remember well the source of this, but 225 can be too much, isn't it? Should we put all of them or only the most use ones?

@sbidoul
Copy link
Member

sbidoul commented Feb 25, 2019

Question is: how to know which are the most used ones? I propose to add them all.

If at some point people combine manual entry of return with PAIN import, one possibility could be adding active flag on return codes so they don't appear in the drop down list, while the import code could still use them.

@ThomasBinsfeld
Copy link
Contributor Author

Would a XML file the best way to embed the 225 return reasons in the module (in terms of maintainability) ? I don't know if it can be done with a CSV file (no noupdate option).

@pedrobaeza
Copy link
Member

As this is standard, it can be tolerable to be put as CSV noupdate=0, as you shouldn't touch here. If you want, then create others. What do you think?

ThomasBinsfeld added a commit to acsone/account-payment that referenced this issue Feb 25, 2019
ThomasBinsfeld added a commit to acsone/account-payment that referenced this issue Feb 25, 2019
ThomasBinsfeld added a commit to acsone/account-payment that referenced this issue Feb 25, 2019
pedrobaeza pushed a commit that referenced this issue Feb 26, 2019
…#228)

* Missing return reasons refs #226 
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
@ThomasBinsfeld
Copy link
Contributor Author

Done in 12.0, I close this issue.

ernestotejeda pushed a commit to Tecnativa/account-payment that referenced this issue Feb 7, 2020
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ernestotejeda pushed a commit to Tecnativa/account-payment that referenced this issue Feb 7, 2020
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
sergio-teruel pushed a commit to Tecnativa/account-payment that referenced this issue Mar 16, 2020
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ernestotejeda pushed a commit to Tecnativa/account-payment that referenced this issue Mar 23, 2020
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
joao-p-marques pushed a commit to Tecnativa/account-payment that referenced this issue Mar 17, 2021
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
polqubiq pushed a commit to QubiQ/account-payment that referenced this issue Apr 7, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
LudLaf pushed a commit to Tecnativa/account-payment that referenced this issue Jun 2, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
LudLaf pushed a commit to Tecnativa/account-payment that referenced this issue Jun 6, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this issue Aug 25, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this issue Sep 30, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ChrisOForgeFlow pushed a commit to ForgeFlow/account-payment that referenced this issue Nov 28, 2022
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
carlosdauden pushed a commit to Tecnativa/account-payment that referenced this issue Mar 7, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
carlosdauden pushed a commit to Tecnativa/account-payment that referenced this issue Mar 7, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
carlosdauden pushed a commit to Tecnativa/account-payment that referenced this issue Mar 20, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
ao-landoo pushed a commit to landoo-es/account-payment that referenced this issue Mar 22, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
Yadier-Tecnativa pushed a commit to Tecnativa/account-payment that referenced this issue Jun 14, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
Ricardoalso pushed a commit to camptocamp/account-payment that referenced this issue Nov 14, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
Ricardoalso pushed a commit to camptocamp/account-payment that referenced this issue Nov 14, 2023
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
carlos-lopez-tecnativa pushed a commit to Tecnativa/account-payment that referenced this issue Jul 24, 2024
…OCA#228)

* Missing return reasons refs OCA#226
* Translations with new return reasons
* name_get: Display name like: "[code] Name"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants