Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] account_due_list_payment_mode: Migration to 15.0 #518

Closed

Conversation

Olageibol
Copy link

No description provided.

cubells and others added 21 commits June 13, 2022 11:56
* Comodel name
* Pylint
[UPD] Update account_due_list_payment_mode.pot
[UPD] Update account_due_list_payment_mode.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
[UPD] Update account_due_list_payment_mode.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-payment-12.0/account-payment-12.0-account_due_list_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list_payment_mode/
[UPD] Update account_due_list_payment_mode.pot

[UPD] README.rst

pre-commit update
Currently translated at 100.0% (1 of 1 strings)

Translation: account-payment-14.0/account-payment-14.0-account_due_list_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_due_list_payment_mode/es_AR/
Currently translated at 100.0% (1 of 1 strings)

Translation: account-payment-14.0/account-payment-14.0-account_due_list_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_due_list_payment_mode/it/
@Olageibol Olageibol mentioned this pull request Jun 13, 2022
23 tasks
@Olageibol Olageibol changed the title 15.0 mig account_due_list_payment_mode [15.0][MIG] account_due_list_payment_mode: Migration to 15.0 Jun 14, 2022
@pedrobaeza
Copy link
Member

/ocabot migration account_due_list_payment_mode

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 1, 2022
@pedrobaeza
Copy link
Member

@Olageibol the version in the manifest, as long as other changes needed for making it work in v15, must be done in the migration commit, not in the [IMP] ...: black, isort, prettier one

@LudLaf
Copy link
Contributor

LudLaf commented Aug 2, 2022

@Olageibol the title of your commit 2b1711bc796dec26f691bf42b8307ed92592b1b1 can be changed to [MIG] account_due_list_payment_mode: Migration to 15.0 for it to be correct.

@LudLaf
Copy link
Contributor

LudLaf commented Aug 2, 2022

.

@pedrobaeza
Copy link
Member

@Olageibol the title of your commit 2b1711bc796dec26f691bf42b8307ed92592b1b1 can be changed to [MIG] account_due_list_payment_mode: Migration to 15.0 for it to be correct.

No, that's not the problem. You have to extract the changes into 2 commits, as stated in the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Copy link
Contributor

@LudLaf LudLaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor

@LudLaf LudLaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is working fine. Tested on runboat.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the pre-commit commit and the migration one (the manifest version bump).

@LudLaf
Copy link
Contributor

LudLaf commented Aug 11, 2022

@Olageibol please modify the commit, so the migration can continue.

@pedrobaeza
Copy link
Member

Superseded by #535

@pedrobaeza pedrobaeza closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.