Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] account_check_printing_report_base: Migration to 15.0 #547

Merged

Conversation

CarlosRoca13
Copy link
Contributor

Changed the way to choose the layout of the check printing, by using the way that odoo uses on core version, and extended the functionality to allow choose that layout at journal level.

cc @Tecnativa TT36415

please @carlosdauden @victoralmau review this

JordiBForgeFlow and others added 30 commits October 5, 2022 09:32
- account_check_printing_report_base
- account_check_printing_report_dlt103
…out verification from config settings, now the module use layout of journal if this have one defined, else use the company's one.
Currently translated at 92.9% (26 of 28 strings)

Translation: account-payment-12.0/account-payment-12.0-account_check_printing_report_base
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_check_printing_report_base/pt/
CarlosRoca13 and others added 7 commits October 5, 2022 09:45
Added the improvement that set the fix of spanish lang, and code to avoid reapeat it
on specific banks modules.
…ix typo in function call

The current version used and installed by Odoo is 0.5.6: https://github.com/odoo/odoo/blob/13.0/requirements.txt#L21
It has a typo in the function call to to_currency where "separator" is spelled "seperator".
As that is the version that Odoo uses, we should adapt to it, and also pin to ensure we are installing the correct one.

The typo is fixed in savoirfairelinux/num2words@2eee037 for version 0.5.10, so we should revert this if we ever upgrade to that version

TT30932
@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-account_check_printing_report_base branch from e2e0b1a to e9b3d94 Compare October 5, 2022 07:55
@oca-clabot
Copy link

Hey @CarlosRoca13, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-account_check_printing_report_base branch from e9b3d94 to 1c383d9 Compare October 6, 2022 10:47
@CarlosRoca13
Copy link
Contributor Author

@carlosdauden Changed!

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-account_check_printing_report_base branch 2 times, most recently from 3706efa to 6541b6d Compare October 31, 2022 15:50
Changed the way to choose the layout of the check printing, by using the
way that odoo uses on core version, and extended the functionality
to allow choose that layout at journal level.

TT36415
@pedrobaeza
Copy link
Member

/ocabot migration account_check_printing_report_base
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 31, 2022
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-547-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit c4bce57 into OCA:15.0 Oct 31, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c051878. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.