Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_voucher_killer: Migration to v15 #713

Merged
merged 24 commits into from
Mar 5, 2024
Merged

[15.0][MIG] account_voucher_killer: Migration to v15 #713

merged 24 commits into from
Mar 5, 2024

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Mar 4, 2024 •
edited
Loading

cc @Tecnativa TT48153

@pedrobaeza @victoralmau please review

anthony-muschang and others added 14 commits March 4, 2024 09:55
@anthony-muschang @pilarvargas-tecnativa
[CHG] rename "invoicing_voucher_killer" to "account_voucher_killer"
b4172a5
@anthony-muschang @pilarvargas-tecnativa
[CHG] account_voucher_killer: add voucher related menus to group "inv…
0c55245 
…oice_voucher_user"
@anthony-muschang @pilarvargas-tecnativa
[CHG] account_voucher_killer: description & hide menu "Sales Receipts…
d5daddc 
… Analysis"
@sbidoul @pilarvargas-tecnativa
[IMP] readme README.md to rst and add credits
bb56ee8
@yvaucher @pilarvargas-tecnativa
Add license key in __openerp__.py
8ffd07e
@gurneyalex @pilarvargas-tecnativa
Add OCA as author of OCA addons
6384ad5 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@phschmidt @pilarvargas-tecnativa
Add requested descriptions in an OCA README.rst file
ebac577
@yvaucher @pilarvargas-tecnativa
Add missing default oca icons
c29e3d5
@sbidoul @pilarvargas-tecnativa
[UPD] prefix versions with 8.0
a6facc1
@pedrobaeza @pilarvargas-tecnativa
[MIG] Make modules uninstallable
55fd295
@oca-transbot @pilarvargas-tecnativa
OCA Transbot updated translations from Transifex
29f0cef
@pedrobaeza @pilarvargas-tecnativa
[IMP] Remove unused POT files
0855c36
@sbidoul @pilarvargas-tecnativa
[FIX] remove en.po that was erroneously created by transbot
afa418b
@pedrobaeza @pilarvargas-tecnativa
[MIG] Rename manifest files
7551c6f
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-mig-account_voucher_killer branch 3 times, most recently from 46a47d5 to 052e9fc Compare March 4, 2024 15:35
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review March 4, 2024 15:42
victoralmau
victoralmau approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-mig-account_voucher_killer branch from 052e9fc to ddee2fa Compare March 5, 2024 07:34
@pedrobaeza
Copy link
Member

/ocabot migration account_voucher_killer

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 5, 2024
Closed
23 tasks
pedrobaeza
pedrobaeza reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please squash administrative commits and some repetitive commits that can be joined from the same author.
  • Put the res.groups in "Extra permissions" group instead of "Technical features".

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-mig-account_voucher_killer branch from ddee2fa to 39e0ff4 Compare March 5, 2024 08:39
@pilarvargas-tecnativa
Copy link
Author

  • Please squash administrative commits and some repetitive commits that can be joined from the same author.
  • Put the res.groups in "Extra permissions" group instead of "Technical features".

done!

pedrobaeza
pedrobaeza approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-713-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5738df into OCA:15.0 Mar 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e6d053f. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-account_voucher_killer branch March 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.