[18.0][MIG] account_payment_line: Migration to 18.0 #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_counterpart_ids exists. Otherwise the method can launch an error when the module has not yet been installed
Currently translated at 100.0% (54 of 54 strings) Translation: account-payment-16.0/account-payment-16.0-account_payment_line Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_payment_line/it/
This was referenced Feb 27, 2025
xaviedoanhduy
force-pushed
the
18.0-mig-account_payment_line
branch
from
797bdc3 to
97e256f
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-account_payment_line
branch
from
97e256f to
85bb240
Compare
Looks good to me. |
wlin-kencove
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in version 18.0:
destination_journal_idandis_internal_transferwere removed from this commit: odoo/odoo@01b87f1nb_daysand removed thebalancefield from payment terms, replacing it with percentage in commit: odoo/odoo@5f37c0434refund_methodfield om modelaccount.move.reversalin commit: odoo/odoo@3a27a4591aml_amount_residualin the constrant to avoid warning log in: https://github.com/odoo/odoo/blob/3217cfa993efdb9da994a6786b9a72a854badcff/odoo/models.py#L919company_idtocompany_ids) in commit: odoo/odoo@0238971astateshave been added on the payment. "Posted" is renamed in "ToProcess" for example, and 3 completely new states are added, see: odoo/odoo@2609fc2e38
on this occasion
defaultattributes ofcompany_idandcurrency_idfields look quite redundant as they are compute fields so take this opportunity to improve them based on currentcompany.account_paymentreplaceaccountdependency to module to avoid error fieldamount_available_for_refundnot defined, ref: https://github.com/odoo/odoo/blob/3217cfa993efdb9da994a6786b9a72a854badcff/addons/account_payment/views/account_payment_views.xml#L1014.0, the_prepare_move_line_default_valsfunction returns 2 or more values (ref), but from16.0onwards, there are only 2 elements in the list (ref). So I took this opportunity to adapt it to version18.0by passing arguments to the original function and super will do the rest.debitandcreditvalues equal to0from the values returned by_prepare_move_line_default_vals