Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_reconcile_oca: Add fields to account.account.reconcile search view #671

Merged

Conversation

victoralmau
Copy link
Member

Add fields to account.account.reconcile search view

ejemplo

Please @pedrobaeza can you review it?

@Tecnativa TT49665

@pedrobaeza pedrobaeza changed the title [15.0][IMP] account_reconcile_oca: Add fields to account.account.reconcile search view [16.0][IMP] account_reconcile_oca: Add fields to account.account.reconcile search view Jun 19, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 19, 2024
@pedrobaeza
Copy link
Member

I don't see this very useful, except for your current debugging case. Do you, @etobella ?

@etobella
Copy link
Member

Well, this is something I missed at some point, so I don't see the problem of adding it 🤔

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-671-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 90cc121 into OCA:16.0 Jun 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

@etobella The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-671-by-etobella-bump-patch:16.0 failed with output:

To https://github.com/OCA/account-reconcile
 ! [rejected]          16.0-ocabot-merge-pr-671-by-etobella-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/account-reconcile'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 95fd921. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants