Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] account_reconcile_oca: Fix the layout of statement button on reconciliation screen #721

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[16.0] [FIX] account_reconcile_oca: Fix the layout of statement button on reconciliation screen #721

merged 1 commit into from
Oct 7, 2024

Conversation

ByteMeAsap
Copy link
Contributor

This Pr aims to fix the layout of statement button on reconciliation screen

Currently, the statement button cuts out some portion of the other parts as seen in following image:

Current Button

After this PR, the button would look as follows:

Button After Changes

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_reconcile_oca-statement_button_layout branch from 05e92bf to ec00aeb Compare October 1, 2024 10:00
flotho
flotho approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise LGTM

account_reconcile_oca/views/account_bank_statement_line.xml Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ByteMeAsap
Copy link
Contributor Author

Can we have this merged?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 7, 2024
pedrobaeza
pedrobaeza requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is incorrect, as the label "STATEMENT" should be in the middle of the line as it was before. If it was overlapping the other text, then you should add height to that section (or compose it other way).

@ByteMeAsap
[FIX] account_reconcile_oca: Fix the layout of statement button on re…
1e7a2c4 
…conciliation screen

Css change

Updated Changes
@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_reconcile_oca-statement_button_layout branch from ec00aeb to 1e7a2c4 Compare October 7, 2024 06:44
@ByteMeAsap
Copy link
Contributor Author

The fix is incorrect, as the label "STATEMENT" should be in the middle of the line as it was before. If it was overlapping the other text, then you should add height to that section (or compose it other way).

@pedrobaeza , I have made changes, please review

@pedrobaeza
Copy link
Member

Can you please put an image of the new after?

@ByteMeAsap
Copy link
Contributor Author

After changes

After Changes

pedrobaeza
pedrobaeza approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that looks better, thanks.

Please fw-port it to 17.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-721-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 742ecb6 into OCA:16.0 Oct 7, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a546457. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@gbrito gbrito gbrito approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ByteMeAsap @OCA-git-bot @pedrobaeza @flotho @gbrito