[18.0][MIG] agreement: Migration to 18.0 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2024
|
/ocabot migration agreement |
|
This PR has the |
sebalix
reviewed
Dec 11, 2024
| @@ -51,8 +51,8 @@ class Agreement(models.Model): | |||
| @api.model | |||
| def _domain_selection(self): | |||
| return [ | |||
| ("sale", _("Sale")), | |||
| ("purchase", _("Purchase")), | |||
| ("sale", self.env._("Sale")), | |||
There was a problem hiding this comment.
Is it pre-commit updating such statements? Or should it be part of the migration commit?
There was a problem hiding this comment.
this should be part of migration commit. I will fix it
agreement/views/agreement.xml.orig
Outdated
| @@ -0,0 +1,135 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
There was a problem hiding this comment.
This file should be removed (local copy?)
we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477
Update agreement and agreement_sale to restore the behavior of v10
…ad of onchange field
Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>
Currently translated at 100.0% (64 of 64 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/
Currently translated at 100.0% (66 of 66 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/
Currently translated at 100.0% (66 of 66 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/
LucasTran380381
force-pushed
the
18.0-mig-agreement
branch
from
8822b10 to
8d0ee19
Compare
LucasTran380381
force-pushed
the
18.0-mig-agreement
branch
from
8d0ee19 to
933cea7
Compare
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4d3a85c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.