[14.0][IMP] Add warning when payment order is not SEPA #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toita86
changed the title
toita86
force-pushed
the
14.0-IMP-account_banking_pain_base-toita86
branch
from
b2cddeb
to
fd445e2
Compare
|
The functional review is correct. |
|
Thanks @anmarmo1 , could you approve the PR? @alexis-via @pedrobaeza was there any problem with this feature in v14? |
|
Second commit is not adding anything. |
GSLabIt
approved these changes
Sep 12, 2024
toita86
force-pushed
the
14.0-IMP-account_banking_pain_base-toita86
branch
from
fd445e2
to
b531dbe
Compare
|
@pedrobaeza good to go? :) |
pedrobaeza
requested changes
Sep 13, 2024
account_banking_pain_base/README.rst
Outdated
| @@ -109,6 +109,8 @@ Contributors | |||
|
|
|||
| * Pedro M. Baeza | |||
| * Carlos Roca | |||
| * `Ooops404 <https://www.ooops404.com/>`_: | |||
There was a problem hiding this comment.
This shouldn't be added, as it's only a cherry-picking
There was a problem hiding this comment.
@pedrobaeza my bad, just fixed!
toita86
force-pushed
the
14.0-IMP-account_banking_pain_base-toita86
branch
from
b531dbe
to
56e0bfb
Compare
The field 'sepa' on account.payment.order is only display for SEPA payment methods. If the option "show warning if not SEPA" is enabled on the payment method, a warning banner is now displayed on payment orders with a SEPA payment method which are not SEPA.
toita86
force-pushed
the
14.0-IMP-account_banking_pain_base-toita86
branch
from
56e0bfb
to
f64f2af
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6de4f7d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting of #1149 needed for OCA/l10n-italy#4367