Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] account_statement_import_online_wise : Migration to 14.0 #601

Merged

Conversation

ecino
Copy link

@ecino ecino commented Jun 1, 2023

No description provided.

@ecino ecino mentioned this pull request Jun 1, 2023
15 tasks
@ecino ecino force-pushed the 14.0-mig-account_statement_import_online_wise branch from 9c54aa1 to 043740a Compare June 1, 2023 09:50
@ecino
Copy link
Author

ecino commented Jun 29, 2023

@alexey-pelykh Willing to review?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alexey-pelykh
Copy link
Contributor

@ecino could you please rebase and push? So that Runboat kicks in

@ecino ecino force-pushed the 14.0-mig-account_statement_import_online_wise branch from 043740a to 31434b7 Compare October 30, 2023 10:05
@alexey-pelykh
Copy link
Contributor

The pre-commit would prevent the automatic merging, otherwise looks good

@ecino
Copy link
Author

ecino commented Oct 30, 2023

@alexey-pelykh Weirdly, the pre-commit doesn't report any issues on my local environment. Not sure what the error is about.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@bosd
Copy link
Contributor

bosd commented Jan 14, 2024

Can you please rebase? Maybe that will fix pre-commit

@ecino ecino force-pushed the 14.0-mig-account_statement_import_online_wise branch from 31434b7 to 92c6948 Compare January 15, 2024 13:19
@ecino
Copy link
Author

ecino commented Jan 15, 2024

@bosd unfortunately not.

@bosd
Copy link
Contributor

bosd commented Jan 15, 2024

I tried to fix in #658.
But it is not enough.

we need manual intervention on po files.
As mentioned in #633.
I don't know how to do that.

Let's hope a maintainer jumps in here.

@ecino
Copy link
Author

ecino commented Feb 12, 2024

Are we good to merge now? Lights are green.

@alexey-pelykh
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@alexey-pelykh The rebase process failed, because command git push --force CompassionCH tmp-pr-601:14.0-mig-account_statement_import_online_wise failed with output:

remote: Permission to CompassionCH/bank-statement-import.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/CompassionCH/bank-statement-import/': The requested URL returned error: 403

@alexey-pelykh
Copy link
Contributor

@ecino not exactly, merge needs to be done as rebase yet bot should take care of that - if that works I'll merge

@alexey-pelykh
Copy link
Contributor

@ecino please do a manual rebase

@ecino ecino force-pushed the 14.0-mig-account_statement_import_online_wise branch from 3f1cfa1 to 4d8afe3 Compare February 12, 2024 14:05
@ecino
Copy link
Author

ecino commented Feb 12, 2024

@alexey-pelykh Rebase done

@alexey-pelykh
Copy link
Contributor

/ocabot migration account_statement_import_online_wise
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Feb 12, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-601-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b7d6c4d into OCA:14.0 Feb 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aae4624. Thanks a lot for contributing to OCA. ❤️

@ecino ecino deleted the 14.0-mig-account_statement_import_online_wise branch February 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants