Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_statement_import_sheet_file: Improve readme #724

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

florenciafrigieri2
Copy link

Improving readme. Adding context.

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Some small comments. Can you review them?

@@ -1,6 +1,35 @@
To create TXT/CSV/XLSX statement sheet columns mapping:
To configure this module, you need to:
1. Install the module account_statement_import_sheet_file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think there is no need to state that we need to install it, isn't it? 😉

@@ -0,0 +1,15 @@
BUSINESS NEED:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest

Business need
~~~~~~~~~~~~~

The same for all titles

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the idea! I'll take the suggestion to the functional group since the titles are not right now in the template, and we should change that first

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from comments from @etobella LGTM

@florenciafrigieri2
Copy link
Author

@etobella Can you solve the squash thing please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants