Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] resource_booking: Add multiples requesters in booking #110

Merged
merged 1 commit into from
Nov 25, 2023
Merged

[15.0][IMP] resource_booking: Add multiples requesters in booking #110

merged 1 commit into from
Nov 25, 2023

Conversation

carolinafernandez-tecnativa
Copy link

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Nov 7, 2023 •
edited
Loading

  • Add multiples requesters in booking

@Tecnativa
TT45338

@pedrobaeza

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 8, 2023
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch 2 times, most recently from b974d43 to c119f30 Compare November 8, 2023 23:46
@pedrobaeza
Copy link
Member

This is not ADD, but IMP, and the commit message shouldn't contain the version.

@carolinafernandez-tecnativa carolinafernandez-tecnativa changed the title [15.0][ADD] resource_booking: Add multiples requesters in booking [15.0][IMP] resource_booking: Add multiples requesters in booking Nov 9, 2023
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch from c119f30 to 1a645fe Compare November 9, 2023 10:29
@carolinafernandez-tecnativa
Copy link
Author

carolinafernandez-tecnativa commented Nov 9, 2023 •
edited
Loading

This is not ADD, but IMP, and the commit message shouldn't contain the version.
Done, thanks!

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch 3 times, most recently from eb83cff to 03787ec Compare November 13, 2023 10:33
pedrobaeza
pedrobaeza reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that now that we put several partners, we should switch the nomenclature from "Requester" to "Attendees". What do you think?

migrations/15.0.1.4.0/pre-migration.py Outdated Show resolved Hide resolved
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch from 03787ec to e2700d2 Compare November 13, 2023 17:34
@carolinafernandez-tecnativa
Copy link
Author

I'm thinking that now that we put several partners, we should switch the nomenclature from "Requester" to "Attendees". What do you think?

I agree. I just changed :)

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch from e2700d2 to 846bd55 Compare November 13, 2023 17:39
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-add-resource_booking-multiple-users branch from 846bd55 to edf6830 Compare November 14, 2023 11:34
pedrobaeza
pedrobaeza approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new feature:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-110-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f5d8eee into OCA:15.0 Nov 25, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f801ef0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-resource_booking-multiple-users branch November 25, 2023 02:00
@pedrobaeza
Copy link
Member

Please review 16.0 migration and then let's include this one after the merge.

chienandalu added a commit to Tecnativa/survey that referenced this pull request Nov 29, 2023
@chienandalu
[FIX] survey_resource_booking: adapt to partner refactor
1fa5c91 
We need to adapt tests to OCA/calendar#110

TT45338
@chienandalu chienandalu mentioned this pull request Nov 29, 2023
Merged
chienandalu added a commit to Tecnativa/calendar that referenced this pull request Nov 29, 2023
@chienandalu
[FIX] resource_booking: inverse partner
781af1d 
Set the inverse for partner_id so modules can adapt seamlessly to the
changes in OCA#110

TT45338
@chienandalu chienandalu mentioned this pull request Nov 29, 2023
Merged
@angelgarciadelachica angelgarciadelachica mentioned this pull request Nov 30, 2023
Merged
victoralmau pushed a commit to Tecnativa/calendar that referenced this pull request Mar 11, 2024
@chienandalu @victoralmau
[FIX] resource_booking: inverse partner
603e84f 
Set the inverse for partner_id so modules can adapt seamlessly to the
changes in OCA#110

TT45338

[BOT] post-merge updates
@carolinafernandez-tecnativa carolinafernandez-tecnativa mentioned this pull request Mar 13, 2024
Merged
3 tasks
isaaccf pushed a commit to isaaccf/calendar that referenced this pull request Sep 5, 2024
@chienandalu @isaaccf-whalar
[FIX] resource_booking: inverse partner
7dd23bd 
Set the inverse for partner_id so modules can adapt seamlessly to the
changes in OCA#110

TT45338

[BOT] post-merge updates
victoralmau pushed a commit to Tecnativa/calendar that referenced this pull request Nov 11, 2024
@chienandalu @victoralmau
[FIX] resource_booking: inverse partner
9e3ae3b 
Set the inverse for partner_id so modules can adapt seamlessly to the
changes in OCA#110

TT45338

[BOT] post-merge updates
Christian-RB pushed a commit to BinhexTeam/survey that referenced this pull request Nov 20, 2024
@chienandalu @Christian-RB
[FIX] survey_resource_booking: adapt to partner refactor
94c95f0 
We need to adapt tests to OCA/calendar#110

TT45338
arielbarreiros96 pushed a commit to BinhexTeam/survey that referenced this pull request Nov 20, 2024
@chienandalu @arielbarreiros96
[FIX] survey_resource_booking: adapt to partner refactor
1ef068f 
We need to adapt tests to OCA/calendar#110

TT45338
Christian-RB pushed a commit to BinhexTeam/survey that referenced this pull request Nov 21, 2024
@chienandalu @Christian-RB
[FIX] survey_resource_booking: adapt to partner refactor
e1d60c3 
We need to adapt tests to OCA/calendar#110

TT45338
arielbarreiros96 pushed a commit to BinhexTeam/survey that referenced this pull request Nov 21, 2024
@chienandalu @arielbarreiros96
[FIX] survey_resource_booking: adapt to partner refactor
15205ca 
We need to adapt tests to OCA/calendar#110

TT45338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carolinafernandez-tecnativa @OCA-git-bot @pedrobaeza