-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] resource_booking: New activity type for resource booking #114
[15.0][IMP] resource_booking: New activity type for resource booking #114
Conversation
Hi @pedrobaeza, |
ab104e7
to
e93ccd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several comments after trying on runboat:
- The mail activity can be created in a day far in the future while the resource booking (RB) is not yet scheduled.
- Once the RB is scheduled, the date of the activity should be synchronized.
- If the RB is cancelled, the activity should be removed.
Hi @pedrobaeza , I have checked your comments. See this example: 1- Created Resource booking for tomorrow for this contact (2024-01-17): 2- Change start date for Resource booking to 2024-01-18 3- Go to the activity and date is updated: 4- Go to Resource booking and cancel it, activity dissapears: |
Try the same without putting immediately the scheduled date on the resource booking, but saving it in "draft" state (you have to go to list view instead of the calendar one). You will see that once you schedule it, the activity is not correctly "rescheduled". And please read the rest of my comment. |
85b2c75
to
924ac24
Compare
924ac24
to
034f4c6
Compare
034f4c6
to
9f1a007
Compare
9f1a007
to
44ae982
Compare
44ae982
to
3cc2e7f
Compare
Some fine-tuning still pending:
@victoralmau can you resume this work to finish this? |
e73ccfc
to
a7a1af9
Compare
Changes done. |
After scheduling (in 2 steps) the resource booking in http://oca-calendar-15-0-pr114-a7a1af9762b1.runboat.odoo-community.org, it still puts the incorrect deadline: And another thing: please add "Re-schedule" button in the activity the same as in meetings. |
a7a1af9
to
4d05ca7
Compare
Changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's working properly. Thanks for the extra feature.
/ocabot merge major
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at edb4707. Thanks a lot for contributing to OCA. ❤️ |
Add new activity type "Resource booking", and when chosen, it takes us to a draft resource booking, where we can define the necessary data. When the appointment is agreed, then the system will create the mail.activity linked to the calendar event generated the reservation booking.
@Tecnativa
TT47152
@pedrobaeza @pilarvargas-tecnativa