Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] resource_booking: New activity type for resource booking #114

Conversation

carolinafernandez-tecnativa
Copy link

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Jan 15, 2024

Add new activity type "Resource booking", and when chosen, it takes us to a draft resource booking, where we can define the necessary data. When the appointment is agreed, then the system will create the mail.activity linked to the calendar event generated the reservation booking.

@Tecnativa
TT47152

@pedrobaeza @pilarvargas-tecnativa

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from ab104e7 to e93ccd8 Compare January 15, 2024 14:43
@carolinafernandez-tecnativa carolinafernandez-tecnativa marked this pull request as ready for review January 15, 2024 14:46
@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 15, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments after trying on runboat:

  • The mail activity can be created in a day far in the future while the resource booking (RB) is not yet scheduled.
  • Once the RB is scheduled, the date of the activity should be synchronized.
  • If the RB is cancelled, the activity should be removed.

@carolinafernandez-tecnativa
Copy link
Author

Several comments after trying on runboat:

  • The mail activity can be created in a day far in the future while the resource booking (RB) is not yet scheduled.
  • Once the RB is scheduled, the date of the activity should be synchronized.
  • If the RB is cancelled, the activity should be removed.

Hi @pedrobaeza , I have checked your comments.

See this example:

1- Created Resource booking for tomorrow for this contact (2024-01-17):

image

2- Change start date for Resource booking to 2024-01-18

image

3- Go to the activity and date is updated:

image

4- Go to Resource booking and cancel it, activity dissapears:

image

image image

@pedrobaeza
Copy link
Member

Try the same without putting immediately the scheduled date on the resource booking, but saving it in "draft" state (you have to go to list view instead of the calendar one). You will see that once you schedule it, the activity is not correctly "rescheduled". And please read the rest of my comment.

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch 2 times, most recently from 85b2c75 to 924ac24 Compare January 22, 2024 11:27
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from 924ac24 to 034f4c6 Compare February 13, 2024 13:20
@carolinafernandez-tecnativa carolinafernandez-tecnativa marked this pull request as draft February 13, 2024 16:12
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from 034f4c6 to 9f1a007 Compare February 13, 2024 16:15
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from 9f1a007 to 44ae982 Compare March 1, 2024 11:36
@carolinafernandez-tecnativa carolinafernandez-tecnativa marked this pull request as ready for review March 1, 2024 11:36
@carolinafernandez-tecnativa carolinafernandez-tecnativa marked this pull request as draft March 1, 2024 11:41
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from 44ae982 to 3cc2e7f Compare March 1, 2024 13:37
@carolinafernandez-tecnativa carolinafernandez-tecnativa marked this pull request as ready for review March 1, 2024 13:38
@pedrobaeza
Copy link
Member

Some fine-tuning still pending:

  • The default view when going to resource booking may it be the form view creating the resource booking directly.
  • Once the date has been scheduled, the linked activity should be updated with the proper deadline.

@victoralmau can you resume this work to finish this?

@victoralmau victoralmau force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch 2 times, most recently from e73ccfc to a7a1af9 Compare March 8, 2024 11:25
@victoralmau
Copy link
Member

Changes done.

@pedrobaeza
Copy link
Member

After scheduling (in 2 steps) the resource booking in http://oca-calendar-15-0-pr114-a7a1af9762b1.runboat.odoo-community.org, it still puts the incorrect deadline:

imagen

And another thing: please add "Re-schedule" button in the activity the same as in meetings.

@victoralmau victoralmau force-pushed the 15.0-imp-resource_booking-open-resource-schedule-activity branch from a7a1af9 to 4d05ca7 Compare March 11, 2024 09:28
@victoralmau
Copy link
Member

Changes done.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's working properly. Thanks for the extra feature.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-114-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d9e90ee into OCA:15.0 Mar 11, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at edb4707. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-resource_booking-open-resource-schedule-activity branch March 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants