[10.0] FIX sale_commission_areamanager: better inheritance of partner view #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tafaRU
approved these changes
Oct 30, 2018
SimoRubi
approved these changes
Oct 30, 2018
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| { | |||
| 'name': 'Sales commission Area Manager', | |||
| 'version': '10.0.1.0.1', | |||
| 'version': '10.0.1.1.0', | |||
There was a problem hiding this comment.
Since this is not a new feature, I'd rather go with '10.0.1.0.2'
|
I used 10.0.1.1.0 because the module needs to be updated
…On 30 October 2018 at 16:59, Simone Rubino ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for you contribution!
Just a small non-blocking note
------------------------------
In sale_commission_areamanager/__manifest__.py
<#184 (comment)>:
> @@ -4,7 +4,7 @@
{
'name': 'Sales commission Area Manager',
- 'version': '10.0.1.0.1',
+ 'version': '10.0.1.1.0',
Since this is not a new feature, I'd rather go with '10.0.1.0.2'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#184 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_Dq0TAHuIs4vjkd4pB0fHQLANN484Tks5uqHdkgaJpZM4YCJx2>
.
--
Lorenzo Battistini
Tel (CH): +41 91 210 23 40
Tel (IT): +39 0331 158 7090
https://www.agilebg.com
https://github.com/eLBati
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.