Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][14.0] sale_commission_salesman #334

Merged
merged 16 commits into from
Mar 23, 2022

Conversation

AntoniRomera
Copy link

No description provided.

pedrobaeza and others added 16 commits January 10, 2022 14:04
This module extends the functionality of `sale_commission` to allow you to
auto-populate salesmen as commission agents without setting explicitly them
on the customer.

**IMPORTANT**: The salesman will be only populated if no other commission agent
is set via other method, to assure that there's no overlapping commissions.

Configuration
=============

* Go to *Contacts*.
* Search for the contact linked to the salesman user and open it.
* If it's actually linked to a user, you'll see a new check in the
  *Agent information* page, called "Convert salesman into agent".
* Check it for having that salesman automatically populated as agent. You
  need to assign a commission to that agent as well.

Usage
=====

To use this module, you need to:

* Go to *Sales > Orders > Quotations* and create a new one.
* Fill the customer with one with no agents set.
* Select a salesman with the mark checked.
* Add a line in the quotation, and you will see the salesman populated as
  commission agent.
* Standard procedure
* Adapt account.invoice > account.move
* Adapt tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es_AR/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es_AR/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es/
Solves [13.0] sale_commission_pricelist - sale_commission_salesman error OCA#274
Co-authored-by: Bhavesh Odedra <bodedra@opensourceintegrators.com>
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/ca/
@AntoniRomera AntoniRomera force-pushed the 14.0-mig-sale_commission_salesman branch from 2e9e4d5 to 7dbf89e Compare January 10, 2022 13:18
Copy link

@FernandoRomera FernandoRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test, ok.

Copy link
Contributor

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, LGTM

@HaraldPanten
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-334-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19b505e into OCA:14.0 Mar 23, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66a623e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

/ocabot migration sale_commission_salesman

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Mar 23, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 23, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.