Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD]sale_commission_settlement_report: manage settlement report visualization #548

Merged

Conversation

PicchiSeba
Copy link

No description provided.

@PicchiSeba PicchiSeba force-pushed the 14.0-add-sale_commission_settlement_report branch from 6c3a55a to 939c97b Compare July 24, 2024 07:46
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@PicchiSeba PicchiSeba force-pushed the 14.0-add-sale_commission_settlement_report branch from 939c97b to 415d6ac Compare July 24, 2024 10:03
Copy link
Contributor

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@francesco-ooops
Copy link
Contributor

@pedrobaeza fixed your comment here: #544 (review)

Could you merge? Thanks!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jul 24, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-548-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5490d69 into OCA:14.0 Jul 24, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f856397. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-add-sale_commission_settlement_report branch July 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants