Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [FIX] sale_commission_check_deposit: check date maturity #549

Conversation

renda-dev
Copy link
Contributor

Check that all of the lines have date_maturity or ignore the invoice.

If an invoice with at least a line without date_maturity is kept in consideration, this would raise an error.

@OCA-git-bot
Copy link
Contributor

Hi @PicchiSeba, @aleuffre,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@renda-dev renda-dev force-pushed the 14.0-fix-sale_commission_check_deposit-all-date-maturity branch from b85a423 to ce6a57c Compare July 23, 2024 14:35
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@aleuffre
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-549-by-aleuffre-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c6a5b7a into OCA:14.0 Jul 23, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 913c93a. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-fix-sale_commission_check_deposit-all-date-maturity branch July 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants