Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [FIX] sale_commission_partial_settlement: reset agent partial #550

Merged

Conversation

renda-dev
Copy link
Contributor

@renda-dev renda-dev commented Jul 25, 2024

Set the invoice line of the agent as not settled if it does not have any settlement linked to it.

Also, proposing me and my team as maintainers of this module.

@renda-dev renda-dev changed the title [FIX] sale_commission_partial_settlement: reset agent partial [14.0] [FIX] sale_commission_partial_settlement: reset agent partial Jul 25, 2024
@renda-dev renda-dev force-pushed the 14.0-fix-sale_commission_partial_settlement branch 3 times, most recently from 1ed872c to cfaa903 Compare July 26, 2024 12:47
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

This PR allows recalculation of settlements for invoices for which settlements had previously been created and deleted (before agent invoice creation)

@renda-dev renda-dev force-pushed the 14.0-fix-sale_commission_partial_settlement branch from cfaa903 to 3963032 Compare July 29, 2024 08:53
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@francesco-ooops
Copy link
Contributor

@pedrobaeza can I ask you to merge this one? Thanks!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jul 29, 2024
@pedrobaeza
Copy link
Member

Merging blindly:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-550-by-pedrobaeza-bump-nobump, awaiting test results.

@francesco-ooops
Copy link
Contributor

Appreciate it!

@OCA-git-bot OCA-git-bot merged commit 39edf07 into OCA:14.0 Jul 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ee21cf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants