Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD]sale_commission_queued: add queue to settlement wizard #554

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

toita86
Copy link

@toita86 toita86 commented Aug 12, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@toita86 toita86 force-pushed the 14.0-ADD-sale_commission_queued-toita86 branch from 8782040 to 285ec15 Compare August 12, 2024 15:36
@pedrobaeza pedrobaeza added this to the 14.0 milestone Aug 12, 2024
@pedrobaeza
Copy link
Member

Please remove me from maintainer, as I don't even touch this module.

@toita86 toita86 force-pushed the 14.0-ADD-sale_commission_queued-toita86 branch from 285ec15 to d1fd694 Compare August 13, 2024 14:52
@toita86 toita86 force-pushed the 14.0-ADD-sale_commission_queued-toita86 branch from d1fd694 to 123caa2 Compare September 13, 2024 14:22
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM. Could you add me as maintainer as well?

@toita86 toita86 force-pushed the 14.0-ADD-sale_commission_queued-toita86 branch from 123caa2 to 88f290d Compare October 21, 2024 07:22
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toita86 toita86 force-pushed the 14.0-ADD-sale_commission_queued-toita86 branch from 88f290d to 8bf6c5a Compare October 23, 2024 11:53
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza can this be merged? thanks!

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-554-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 911ebd3 into OCA:14.0 Oct 23, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ae70ced. Thanks a lot for contributing to OCA. ❤️

@toita86 toita86 deleted the 14.0-ADD-sale_commission_queued-toita86 branch October 24, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants