Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [MIG] base_currency_iso_4217: Migration to v14 #102

Merged
merged 8 commits into from
Apr 9, 2021
Merged

[14.0] [MIG] base_currency_iso_4217: Migration to v14 #102

merged 8 commits into from
Apr 9, 2021

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT26428

please review this migration @joao-p-marques @carlosdauden

@CarlosRoca13 CarlosRoca13 mentioned this pull request Jan 15, 2021
Merged
joao-p-marques
joao-p-marques approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

About the translation, I don't know if this would be a better alternative. Not very important, though.

base_currency_iso_4217/i18n/es.po Outdated Show resolved Hide resolved
@CarlosRoca13 CarlosRoca13 force-pushed the 14.0-MIG-base_currency_iso_4217 branch from 6a90d81 to e34dd48 Compare January 18, 2021 08:57
@CarlosRoca13
Copy link
Contributor Author

I applied the changes @joao-p-marques, thanks for the revision

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd bosd mentioned this pull request Mar 6, 2021
Closed
8 tasks
@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-102-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dd11225 into OCA:14.0 Apr 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c5ba6e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-p-marques joao-p-marques joao-p-marques approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@CarlosRoca13 @OCA-git-bot @StefanRijnhart @carlosdauden @joao-p-marques @JordiBForgeFlow @lk-eska @MiquelRForgeFlow @bosd