Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] uom_unece: Change unit code from C62 to PCE #202

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

Rad0van
Copy link

@Rad0van Rad0van commented Jul 12, 2024

According to https://www.gs1us.org/resources/data-hub-help-center/unit-of-measure-codes C62 means one while PCE means piece. I think PCE is correct as for example dozen is encoded as DPC meaning dozen piece.

@OCA-git-bot
Copy link
Contributor

Hi @astirpe, @alexis-via,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 17.0 milestone Jul 12, 2024
@pedrobaeza
Copy link
Member

@Rad0van Rad0van changed the title [17.0][IMP] Change unit code from C62 to PCE [IMP] uom_unece: Change unit code from C62 to PCE Jul 12, 2024
@Rad0van
Copy link
Author

Rad0van commented Jul 12, 2024

Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Thanks Pedro for reminder. Need to remind this once for all.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the PCE is the old code.
The new recomended code is H87.
See:
https://www.gs1.org/standards/eancom/eancom-2002-edition-2016/eancom-syntax-3
click on:
Part III: Data elements & code sets directory
then go to:
2. Index by data element name
search for:
Measurement unit code

Then you will reach this page..

Measurement unit code

Where the recomended codes are explained.

image

@@ -2,7 +2,7 @@
<odoo>
<!-- Units -->
<record id="uom.product_uom_unit" model="uom.uom">
<field name="unece_code">C62</field>
<field name="unece_code">PCE</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="unece_code">PCE</field>
<field name="unece_code">H87</field>

@bosd
Copy link
Contributor

bosd commented Nov 15, 2024

We need a migration script for this change as well.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants