-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] uom_unece: Change unit code from C62 to PCE #202
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @astirpe, @alexis-via, |
Please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message |
Thanks Pedro for reminder. Need to remind this once for all. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the PCE is the old code.
The new recomended code is H87
.
See:
https://www.gs1.org/standards/eancom/eancom-2002-edition-2016/eancom-syntax-3
click on:
Part III: Data elements & code sets directory
then go to:
2. Index by data element name
search for:
Measurement unit code
Then you will reach this page..
Where the recomended codes are explained.
@@ -2,7 +2,7 @@ | |||
<odoo> | |||
<!-- Units --> | |||
<record id="uom.product_uom_unit" model="uom.uom"> | |||
<field name="unece_code">C62</field> | |||
<field name="unece_code">PCE</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="unece_code">PCE</field> | |
<field name="unece_code">H87</field> |
We need a migration script for this change as well. |
According to https://www.gs1us.org/resources/data-hub-help-center/unit-of-measure-codes C62 means one while PCE means piece. I think PCE is correct as for example dozen is encoded as DPC meaning dozen piece.