[17.0][FIX] base_bank_from_iban: Handle correctly non IBAN accounts #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any non IBAN account is provided, there's an ugly log with traceback
each time, polluting tests and system logs:
```
INFO prod odoo.addons.base_bank_from_iban.models.res_partner_bank: Could not find bank from IBAN
Traceback (most recent call last):
File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 34, in _add_bank_vals
bank = self._get_bank_from_iban(vals["acc_number"])
File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 42, in _get_bank_from_iban
iban = schwifty.IBAN(acc_number)
File ".../python/site-packages/schwifty/iban.py", line 77, in __init__
self.validate(validate_bban)
File ".../python/site-packages/schwifty/iban.py", line 175, in validate
self._validate_characters()
File ".../python/site-packages/schwifty/iban.py", line 185, in _validate_characters
raise exceptions.InvalidStructure(f"Invalid characters in IBAN {self!s}")
schwifty.exceptions.InvalidStructure: Invalid characters in IBAN XXXXXX
```
This commit removes that traceback catching the proper exception, and
handling it accordingly, and also removing an extra INFO log that was
not adding value.
chienandalu
approved these changes
Nov 7, 2024
|
Let's finish the chain: /ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0435437. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #206 and #212
If any non IBAN account is provided, there's an ugly log with traceback each time, polluting tests and system logs:
This commit removes that traceback catching the proper exception, and handling it accordingly, and also removing an extra INFO log that was not adding value.
@Tecnativa