Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ignore dbfilter, fixes #58 #165

Closed
wants to merge 1 commit into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Dec 27, 2015

dbfilter can contains %d or %h, referring to the client hostname.
Since connector does run independently of client, it can not rely
on the dbfilter concept.

@sbidoul
Copy link
Member Author

sbidoul commented Dec 27, 2015

Perhaps this one should wait 4.0 as it can change the behaviour of some installations relying on dbfilter. #166 could be used for 3.x.

@sbidoul sbidoul force-pushed the 8.0-no-dbfilter-sbi branch from 14b2dc8 to 8461fba Compare December 27, 2015 12:49
@pedrobaeza
Copy link
Member

I don't think this can cause any side effect. Do you?

@guewen
Copy link
Member

guewen commented Jan 4, 2016

It seems to me that if one uses %d or %h, it works by chance.

Anyway what we can do is:

  1. Merge [FIX] ignore dbfilter containing %d or %h, fixes #58 #166 in 8.0
  2. Tag HEAD of 8.0 as 8.0.3.3.0
  3. Merge [FIX] ignore dbfilter, fixes #58 #165, next planned release being 8.0.4.0.0

What do you think?

Thanks for the correction!

@lmignon
Copy link
Contributor

lmignon commented Jan 4, 2016

👍 with the proposal of @guewen

@sbidoul sbidoul force-pushed the 8.0-no-dbfilter-sbi branch from 8461fba to 7354724 Compare January 4, 2016 09:14
@pedrobaeza pedrobaeza mentioned this pull request Feb 4, 2016
5 tasks
@lmignon lmignon mentioned this pull request Feb 15, 2016
5 tasks
@sbidoul
Copy link
Member Author

sbidoul commented Feb 29, 2016

@guewen @lmignon this one to be included in the 9.0 version?

@lmignon
Copy link
Contributor

lmignon commented Feb 29, 2016

@sbidoul 9.0 has been rebased on the latest 8.0 2 hours ago and also include #165

@guewen
Copy link
Member

guewen commented Feb 29, 2016

@lmignon the latest 8.0 contains #166 which is the backward compatible fix but not #165. I agree with @sbidoul to integrate this one in 9.0.

@lmignon
Copy link
Contributor

lmignon commented Feb 29, 2016

@guewen @sbidoul done acsone@bdf9bbf

@guewen
Copy link
Member

guewen commented Feb 29, 2016

thanks @lmignon !

@sbidoul
Copy link
Member Author

sbidoul commented Feb 29, 2016

@lmignon that's an empty commit 😉 I had missed it but it was already in your PR at acsone@3c83de4.

So we can close this one as it is taken into account in #169

@sbidoul sbidoul closed this Feb 29, 2016
@sbidoul sbidoul deleted the 8.0-no-dbfilter-sbi branch February 29, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants