Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to assign a default channel on @job functions #71

Merged
merged 2 commits into from
May 27, 2015

Conversation

guewen
Copy link
Member

@guewen guewen commented May 27, 2015

When the @job is registered and created in the database, it lookups its
channel and creates it if it don't exist yet.

Allows to do:

@job(default_channel='root.channel.subchannel')
def a_task(session, arg):
    pass

Also add tests on jobs and channels models

When the @job is registered and created in the database, it lookups its channel
and creates it if it don't exist yet.
@guewen
Copy link
Member Author

guewen commented May 27, 2015

I thought it was merged in the jobrunner branch but it appears it wasn't. Thus I propose it again on the 8.0 branch.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.56%) to 75.14% when pulling b299b6b on guewen:default-channels-on-jobs into aa5cf84 on OCA:8.0.

@sbidoul
Copy link
Member

sbidoul commented May 27, 2015

It must have been lost in the last rebase, sorry.

👍

@guewen
Copy link
Member Author

guewen commented May 27, 2015

It must have been lost in the last rebase, sorry.

No problem :-)

@lmignon
Copy link
Sponsor Contributor

lmignon commented May 27, 2015

👍

1 similar comment
@yvaucher
Copy link
Member

👍

yvaucher added a commit that referenced this pull request May 27, 2015
Allow to assign a default channel on @job functions
@yvaucher yvaucher merged commit 9e66233 into OCA:8.0 May 27, 2015
@guewen guewen deleted the default-channels-on-jobs branch May 27, 2015 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants