Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] Add variable qty to contract template view #66

Merged

Conversation

lasley
Copy link
Contributor

@lasley lasley commented May 6, 2017

Allows templating of the variable qty lines by updating the account.analytic.contract view.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change version

@@ -4,7 +4,7 @@

{
'name': 'Variable quantity in contract recurrent invoicing',
'version': '10.0.1.0.0',
'version': '10.0.1.0.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change minor version, not revision

@lasley
Copy link
Contributor Author

lasley commented May 6, 2017

Thanks for the review @pedrobaeza - done

@rafaelbn rafaelbn added this to the 10.0 milestone May 6, 2017
@rafaelbn
Copy link
Member

rafaelbn commented May 6, 2017

Hi @lasley , sorry but I'm not able to create contract templates. I tried #68 and also same error if I go to Accounting -> Configuration -> Contracts -> Contracts templates

@lasley
Copy link
Contributor Author

lasley commented May 8, 2017

@rafaelbn - looks like the issue is related to pricelists. For the purpose of this review, we can just not select a pricelist when creating a contract template in order to circumvent.

I'll submit a separate PR for the fix in order to avoid expanding the scope of this feature with a bug fix.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks1

@rafaelbn rafaelbn merged commit c0bc0b3 into OCA:10.0 Jun 9, 2017
@lasley lasley deleted the feature/10.0/contract_variable_qty_template branch June 13, 2017 20:14
carlosdauden pushed a commit to Tecnativa/contract that referenced this pull request Jan 9, 2018
* [IMP] Add variable qty to contract template view

* Bump minor version
sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Nov 6, 2018
* [IMP] Add variable qty to contract template view

* Bump minor version
sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019
* [IMP] Add variable qty to contract template view

* Bump minor version
sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019
* [IMP] Add variable qty to contract template view

* Bump minor version

OCA Transbot updated translations from Transifex
sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019
* [IMP] Add variable qty to contract template view

* Bump minor version

OCA Transbot updated translations from Transifex
CarlosRoca13 pushed a commit to Tecnativa/contract that referenced this pull request Oct 27, 2020
* [IMP] Add variable qty to contract template view

* Bump minor version
victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Sep 23, 2021
* [IMP] Add variable qty to contract template view

* Bump minor version
olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021
* [IMP] Add variable qty to contract template view

* Bump minor version
victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Nov 3, 2022
* [IMP] Add variable qty to contract template view

* Bump minor version
victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Nov 3, 2022
* [IMP] Add variable qty to contract template view

* Bump minor version
aktiv-heli-kantawala pushed a commit to aktiv-heli-kantawala/contract that referenced this pull request Jun 6, 2023
* [IMP] Add variable qty to contract template view

* Bump minor version
brian10048 pushed a commit to brian10048/contract that referenced this pull request Dec 1, 2023
* [IMP] Add variable qty to contract template view

* Bump minor version
brian10048 pushed a commit to brian10048/contract that referenced this pull request Dec 1, 2023
* [IMP] Add variable qty to contract template view

* Bump minor version
carolinafernandez-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jan 5, 2024
* [IMP] Add variable qty to contract template view

* Bump minor version
carolinafernandez-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jan 5, 2024
* [IMP] Add variable qty to contract template view

* Bump minor version
juanjosesegui-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jul 22, 2024
* [IMP] Add variable qty to contract template view

* Bump minor version
sbejaoui pushed a commit to acsone/contract that referenced this pull request Nov 4, 2024
* [IMP] Add variable qty to contract template view

* Bump minor version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants