[15.0][IMP] subscription_oca: Tests, refactoring #991
Conversation
ilyasProgrammer
force-pushed
the
15.0-subscription_oca-tests
branch
from
ee35f1c
to
2996dd0
Compare
|
@carlos-domatix what do you think about tests? @simahawk implementation of #971 (review) |
| cls.product_1 = cls.env.ref("product.product_product_1") | ||
| cls.product_1.taxes_id = [(6, 0, cls.tax_10pc_incl.ids)] | ||
| cls.product_2 = cls.env.ref("product.product_product_2") | ||
| cls.country_id = cls.env["res.country"].search([], limit=1) |
There was a problem hiding this comment.
| cls.country_id = cls.env["res.country"].search([], limit=1) | |
| cls.country = cls.env["res.country"].search([], limit=1) |
to do for all vars that are records and not IDs
| } | ||
| ) | ||
|
|
||
| def test_all_subscription_oca(self): |
There was a problem hiding this comment.
Any major reason to have just one biiiig test?
Still better than nothing of course :)
If you don't have time, add a TODO for splitting it
| self.assertIsInstance(move_res, dict) | ||
|
|
||
| # sale.subscription | ||
| self.sub_id.cron_subscription_management() |
There was a problem hiding this comment.
this should go to one or more cron specific tests
| # sale.subscription.stage | ||
| self.stage_id._check_lot_product() # should not raise | ||
|
|
||
| # sale.subscription.template |
ilyasProgrammer
force-pushed
the
15.0-subscription_oca-tests
branch
from
b8c4ca9
to
7c003ce
Compare
|
@simahawk Thanks for the review. Please have a look again. |
|
Thanks a lot for the effort. I see it well but it has 70% coverage https://app.codecov.io/gh/OCA/contract/tree/15.0-subscription_oca-tests/, I don't know if it is enough for the repo, but at least it is a good base. |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 7af1620. Thanks a lot for contributing to OCA. ❤️ |
No description provided.