[16.0][MIG] account_credit_control #268

astirpe · 2023-02-28T15:13:10Z

Continue from #242

Bearnard21

There's an error when you try to get into the partner (no matter if it's a customer or vendor).
The error code:

`Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 1584, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/odoo/service/model.py", line 134, in retrying
result = func()
File "/opt/odoo/odoo/http.py", line 1613, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/odoo/http.py", line 1810, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 149, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/odoo/http.py", line 699, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/odoo/api.py", line 457, in call_kw
result = _call_kw_model(method, model, args, kwargs)
File "/opt/odoo/odoo/api.py", line 430, in _call_kw_model
result = method(recs, *args, **kwargs)
File "/opt/odoo/odoo/models.py", line 1605, in name_search
ids = self._name_search(name, args, operator, limit=limit)
File "/opt/odoo/odoo/models.py", line 1624, in _name_search
return self._search(args, limit=limit, access_rights_uid=name_get_uid)
File "/opt/odoo/odoo/models.py", line 4624, in _search
query = self._where_calc(domain)
File "/opt/odoo/odoo/models.py", line 4392, in _where_calc
return expression.expression(domain, self).query
File "/opt/odoo/odoo/osv/expression.py", line 447, in init
self.parse()
File "/opt/odoo/odoo/osv/expression.py", line 849, in parse
ids2 = comodel._name_search(right, domain or [], op2, limit=None)
File "/opt/odoo/addons/account/models/account_account.py", line 580, in _name_search
return self._search(expression.AND([domain, args]), limit=limit, access_rights_uid=name_get_uid)
File "/opt/odoo/odoo/models.py", line 4624, in _search
query = self._where_calc(domain)
File "/opt/odoo/odoo/models.py", line 4392, in _where_calc
return expression.expression(domain, self).query
File "/opt/odoo/odoo/osv/expression.py", line 447, in init
self.parse()
File "/opt/odoo/odoo/osv/expression.py", line 1024, in parse
expr, params = self.__leaf_to_sql(leaf, model, alias)
File "/opt/odoo/odoo/osv/expression.py", line 1100, in __leaf_to_sql
raise ValueError("Invalid domain term %r" % (leaf,))
ValueError: Invalid domain term ('name', 'in', 'property_account_receivable_id')

The above server error caused the following client error:
null`

astirpe · 2023-03-07T09:28:31Z

Thank you @Bearnard21, should be working now

nguyenminhchien

Hi @astirpe, i just added some comments, feel free to discuss with me bout them.
Thank you,

account_credit_control/README.rst

account_credit_control/views/credit_control_line.xml

account_credit_control/views/credit_control_communication.xml

nguyenminhchien · 2023-03-24T04:44:01Z

account_credit_control/models/credit_control_policy.py

+        to_add, to_remove = self._get_partner_related_lines(credit_control_run)
+        lines = (lines | to_add) - to_remove
+        to_add, to_remove = self._get_invoice_related_lines(credit_control_run)
+        lines = (lines | to_add) - to_remove


Because all invoice lines must be for a particular company. I cannot find the case where (lines | to_add) != lines.
I mean that we don't need to_add in both cases _get_partner_related_lines and _get_invoice_related_lines.

I tend to agree with you, but I don't know why this part was implemented this way. Maybe to allow _get_partner_related_lines and _get_invoice_related_lines to be extended by extra modules?

Yes, maybe. So, just let to_add = self.env["account.move.line"] in def _move_lines_subset()
Extended modules will update it then

account_credit_control/security/acl_account_credit_control_analysis.xml

account_credit_control/security/acl_res_partner_payment_action_type.xml

account_credit_control/wizard/credit_control_policy_changer_view.xml

nguyenminhchien · 2023-03-24T04:59:23Z

account_credit_control/wizard/credit_control_policy_changer_view.xml

+        </field>
+    </record>
+    <!-- for button -->
+    <record id="action_wizard_credit_policy_changer" model="ir.actions.act_window">


cannot find a menu call this action

Me neither, I'm trying to understand how was this originally supposed to work

You should add a new menu to call this action, or delete it.

* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations

* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template

* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report

* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation

* Translation + report invoice address layout * Label Force credit control policy + french translation

…when partners or accounts are duplicated

…e in non draft state before deleting it

* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'

…ranslation extraction

* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP. * bug 1287072 Level calculation error if previous credit line is ignored * unifing wizard views to respect UI guide lines * credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice * test to ensure that wizard run on customer invoice * Scenario that test coherence of credit run after manually altering an invoice level * multicurrency in communication * ...

…ding _unported suffix

astirpe · 2023-03-30T08:30:33Z

@nguyenminhchien regarding the two points left, I understand your proposal but I'm not yet fully convinced I want to change that part of code. Maybe the authors of that part could join the discussion, but for the time being I would leave it as it is, since this PR was meant to be a pure module migration. Do you mind to let the discussion continue on a separate PR once this one is merged?

nguyenminhchien

@astirpe: it's ok

GabbasovDinar

Code LGTM

victoralmau · 2023-04-20T06:06:12Z

Please, cherry-pick #279 to commit history

astirpe · 2023-04-20T07:24:24Z

@victoralmau

your migration scripts are for V15, so no need to include them in this PR
the changes in the mail template were already implemented in February within this PR, so your PR seems to me a backport from this PR. Anyway I don't see anything to be cherry picked from [15.0][OU-ADD] account_credit_control: Add forgotten migration script #279

Bearnard21

Credit control policy level form check

A check is performed after all policy levels were added to the credit control policy form. In case you've missed the custom mail message field in any of the credit control policy levels, you will get a warning on saving the whole policy. If there are several levels that were added, it's pretty inconvenient to check all the policy levels to find the missing field, so it would be nice if a check will be performed right on the policy level form.
In case you've chosen phone call action, you still have to fill mandatory e-mail template field.
If you're making changes in created policy level (eg. changing the channel from phone to e-mail), checking on the custom mail message field is not performed.

astirpe · 2023-05-08T11:06:46Z

@Bearnard21 I see.

Point 1 and 3 are something related to a common issue of HTML fields, so I don't think there's a quick way to fix it within this PR. I found an old discussion where this issue is explained more in details: https://www.odoo.com/forum/help-1/how-to-make-a-html-field-mandatory-in-the-form-161104

For point 2 I agree that it's something should be fixed, but is a problem already existing in previous versions of this module, so I think it's better to open a dedicated issue for that. What do you think?

Bearnard21 · 2023-05-22T05:09:29Z

Sorry for replying late,
Points 1 and 3
You can override the "New" method and recall function that sets up constrain for HTML to perform a check of the new policy right on a form view. Just keep in mind that the empty HTML field contains 12 symbols.
Talking about point 2
Asking me, I think that improvement could be done in this PR.

astirpe · 2023-05-22T06:57:25Z

@Bearnard21 please go ahead and open a PR to fix your points on previous versions. I will cherry pick your fixes to include them in this PR. Thanks!

Bearnard21

Changes requested to be commited in next PR

OCA-git-bot · 2023-05-23T13:39:18Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-05-23T13:39:18Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana · 2023-05-29T09:59:49Z

merge?

pedrobaeza · 2023-05-29T12:05:13Z

/ocabot migration account_credit_control
/ocabot merge nobump

OCA-git-bot · 2023-05-29T12:05:25Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-268-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-05-29T12:11:12Z

Congratulations, your PR was merged at cc55cd4. Thanks a lot for contributing to OCA. ❤️

grindtildeath · 2023-06-02T15:30:18Z

account_credit_control/models/credit_control_run.py

+        action_name = "account_credit_control.credit_control_line_action"
+        action = self.env.ref(action_name)
+        action = action.read()[0]


This will raise AccessError for anyone not member of Settings/Administration group. Proper way to do it is:

action_name = "account_credit_control.credit_control_line_action" action = self.env["ir.actions.act_window"]._for_xml_id(action_name)

That seems to be missing in the migration guide actually 😕

Thank you! I opened #287

astirpe force-pushed the 16_mig_account_credit_control branch 2 times, most recently from 7c6023d to 63d001d Compare February 28, 2023 15:40

astirpe marked this pull request as ready for review February 28, 2023 15:43

Bearnard21 suggested changes Mar 6, 2023

View reviewed changes

astirpe force-pushed the 16_mig_account_credit_control branch 4 times, most recently from 71ff07b to 11a8a60 Compare March 7, 2023 09:27

astirpe force-pushed the 16_mig_account_credit_control branch from 11a8a60 to 4032416 Compare March 7, 2023 09:33

nguyenminhchien reviewed Mar 24, 2023

View reviewed changes

nguyenminhchien mentioned this pull request Mar 24, 2023

[16.0][MIG] account_credit_control_dunning_fees: Migration to 16.0 nguyenminhchien/credit-control#1

Closed

@ and others added 18 commits March 27, 2023 16:19

[MIG] account_credit_control: Renamed and migrated to 6.1

61725ed

[MIG] account_credit_control: Migration to 7.0

dd486f1

[IMP] account_credit_control: Add scenarios

7c71bf9

[IMP+FIX] account_credit_control: Several improvements & fixes

e89162b

* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations

[FIX+IMP] account_credit_control

32d3369

* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report

[FIX] account_credit_control:

825f3d7

* Translation + report invoice address layout * Label Force credit control policy + french translation

[FIX] account_credit_control: Do not copy lines credit control lines …

f3689da

…when partners or accounts are duplicated

[FIX] account_credit_control: Test if invoice have credit control lin…

f587299

…e in non draft state before deleting it

[IMP+FIX] account_credit_control:

3263ab7

* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'

[FIX] account_credit_control - add encoding on mako template to fix t…

6bba829

…ranslation extraction

[FIx] Add active on credit control policy in order to deactivate it

2862de7

[FIX] move all unported addons into __unported__ folder instead of ad…

99d4c13

…ding _unported suffix

[MIG] account_credit_control: Migration to 8.0

cef8229

[IMP] Include the fees in the total due

3287b39

[DEL] Group access for transient model

2312185

This was referenced Mar 29, 2023

[16.0][MIG] account_credit_control_dunning_fees: Migration to 16.0 nguyenminhchien/credit-control#2

Open

[16.0][MIG] account_credit_control_dunning_fees: Migration to 16.0 #274

Merged

[16.0][MIG] account_credit_control (code review)

0d1e8c4

astirpe force-pushed the 16_mig_account_credit_control branch from 9994273 to 0d1e8c4 Compare March 30, 2023 08:22

nguyenminhchien approved these changes Mar 31, 2023

View reviewed changes

GabbasovDinar approved these changes Apr 10, 2023

View reviewed changes

Bearnard21 suggested changes May 3, 2023

View reviewed changes

Bearnard21 approved these changes May 23, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels May 23, 2023

OCA-git-bot added this to the 16.0 milestone May 29, 2023

OCA-git-bot mentioned this pull request May 29, 2023

Migration to version 16.0 #220

Open

12 tasks

OCA-git-bot added the bot is merging ⏳ label May 29, 2023

OCA-git-bot merged commit 64dfbb3 into OCA:16.0 May 29, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 29, 2023

grindtildeath reviewed Jun 2, 2023

View reviewed changes

astirpe mentioned this pull request Jun 5, 2023

[16.0][FIX] account_credit_control: avoid AccessError in open_credit_lines() #287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_credit_control #268

[16.0][MIG] account_credit_control #268

astirpe commented Feb 28, 2023

Bearnard21 left a comment

astirpe commented Mar 7, 2023

nguyenminhchien left a comment

nguyenminhchien Mar 24, 2023

astirpe Mar 27, 2023

nguyenminhchien Mar 30, 2023

nguyenminhchien Mar 24, 2023

astirpe Mar 27, 2023

nguyenminhchien Mar 30, 2023

astirpe commented Mar 30, 2023

nguyenminhchien left a comment

GabbasovDinar left a comment

victoralmau commented Apr 20, 2023

astirpe commented Apr 20, 2023

Bearnard21 left a comment

astirpe commented May 8, 2023

Bearnard21 commented May 22, 2023

astirpe commented May 22, 2023

Bearnard21 left a comment

OCA-git-bot commented May 23, 2023

OCA-git-bot commented May 23, 2023

andreampiovesana commented May 29, 2023

pedrobaeza commented May 29, 2023

OCA-git-bot commented May 29, 2023

OCA-git-bot commented May 29, 2023

grindtildeath Jun 2, 2023

astirpe Jun 5, 2023

[16.0][MIG] account_credit_control #268

[16.0][MIG] account_credit_control #268

Conversation

astirpe commented Feb 28, 2023

Bearnard21 left a comment

Choose a reason for hiding this comment

astirpe commented Mar 7, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe commented Mar 30, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

GabbasovDinar left a comment

Choose a reason for hiding this comment

victoralmau commented Apr 20, 2023

astirpe commented Apr 20, 2023

Bearnard21 left a comment

Choose a reason for hiding this comment

astirpe commented May 8, 2023

Bearnard21 commented May 22, 2023

astirpe commented May 22, 2023

Bearnard21 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 23, 2023

OCA-git-bot commented May 23, 2023

andreampiovesana commented May 29, 2023

pedrobaeza commented May 29, 2023

OCA-git-bot commented May 29, 2023

OCA-git-bot commented May 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment