Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] crm_lead_website: Migration to 10.0 #151

Merged
merged 6 commits into from
May 31, 2017
Merged

[MIG] crm_lead_website: Migration to 10.0 #151

merged 6 commits into from
May 31, 2017

Conversation

chienandalu
Copy link
Member

  • Migrate tweaks
  • Adapt methodsº

cc @Tecnativa

yajo
yajo approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment.

Would be nice if you squash translation commits.

crm_lead_website/models/crm_lead.py Outdated
@@ -0,0 +1,29 @@
# -*- coding: utf-8 -*-
# © 2015 Antiun Ingeniería, S.L.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer Antiun's.

luismontalba
luismontalba reviewed May 31, 2017
View reviewed changes
crm_lead_website/README.rst Outdated
To see some effects of this module, you need to enable leads:

#. Enable *Sales > Configuration > Settings > Use leads if you need a
qualification step before creating an opportunity or a customer*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRM > Configuration > Settings

@chienandalu chienandalu force-pushed the 10.0-mig-crm_lead_website branch from 6665ffa to 94c1241 Compare May 31, 2017 08:20
@chienandalu chienandalu force-pushed the 10.0-mig-crm_lead_website branch from 94c1241 to 1e6c146 Compare May 31, 2017 08:21
@yajo yajo added this to the 10.0 milestone May 31, 2017
rafaelbn
rafaelbn approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot 👍

@rafaelbn rafaelbn merged commit 74421d8 into OCA:10.0 May 31, 2017
@yajo yajo deleted the 10.0-mig-crm_lead_website branch June 1, 2017 11:31
@pedrobaeza pedrobaeza mentioned this pull request Jun 8, 2017
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@luismontalba luismontalba luismontalba approved these changes

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chienandalu @yajo @luismontalba @rafaelbn @pedrobaeza @oca-transbot