[10.0][MIG] crm_location #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is failing due to this module depends on base_location located in OCA/partner-contact repo. |
|
It shouldn't fail, because you can specify on oca_repositories.txt these kind of dependencies. |
pedrobaeza
requested changes
Jun 9, 2017
crm_location/models/crm_lead.py
Outdated
| res = super(CrmLead, self).on_change_partner_id(partner_id) | ||
| if 'value' not in res: | ||
| res['value'] = {} | ||
| def _onchange_partner_id_values(self, partner_id): |
There was a problem hiding this comment.
This old onchange doesn't work for sure. Please use new API onchange (you can create a new method for not having to overwrite super):
@api.onchange('partner_id')
def onchange_partner_id_crm_location(self):
if self.partner_id:
self.location_id = self.partner_id.zip_id.id
| location = self.location | ||
| partner.zip_id = location.id | ||
| lead.partner_id = partner.id | ||
| lead._onchange_partner_id_values(lead.partner_id.id) |
There was a problem hiding this comment.
Call the new onchange method.
luismontalba
force-pushed
the
10.0-mig-crm_location
branch
from
f1a9ace to
bd87d57
Compare
|
Changes proposed done and own commits squashed. |
yajo
approved these changes
Jun 12, 2017
crm_location/__manifest__.py
Outdated
| 'depends': [ | ||
| 'crm', | ||
| 'base_location', | ||
| ], | ||
| 'data': ['views/crm_lead_view.xml'], | ||
| 'author': 'Antiun Ingeniería S.L., ' | ||
| 'author': 'Antiun Ingeniería, ' |
There was a problem hiding this comment.
Better to replace, as this version is not maintained anymore by these old companies
luismontalba
force-pushed
the
10.0-mig-crm_location
branch
from
bd87d57 to
3876317
Compare
|
Author replaced, new commit squashed. |
pedrobaeza
force-pushed
the
10.0-mig-crm_location
branch
from
3876317 to
7461c1b
Compare
pedrobaeza
approved these changes
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRM location
This module introduces a better zip.
It enables zip, city, state and country auto-completion on lead.
cc @Tecnativa